cdc: fix old value config glitch when changefeeds with different settings connect to one region #9515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zixiong Liu <[email protected]>
ti-srebot
added
the
first-time-contributor
ti-chi-bot
added
the
size/L
liuzix
force-pushed
the
zixiong-fix-old-value
branch
from
ebf9ab1 to
a2cc5ce
Compare
5kbpers
reviewed
Jan 18, 2021
| let mut event_count = 0; | ||
| loop { | ||
| let events = receive_event_1(false).events.to_vec(); | ||
| println!("test_old_value_multi_changefeeds: 3"); |
|
/lgtm |
Signed-off-by: Zixiong Liu <[email protected]>
|
@amyangfei: Please use If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature. If you have any qustions please refer to lgtm command help or lgtm plugin design. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/lgtm |
ti-chi-bot
added
status/LGT2
|
/merge |
|
@5kbpers: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 15f3291
|
ti-chi-bot
added
the
status/can-merge
|
@liuzix: Your PR has out-of-dated, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
5kbpers
added
the
needs-cherry-pick-release-4.0
|
/run-cherry-picker |
ti-srebot
pushed a commit
to ti-srebot/tikv
that referenced
this pull request
Jan 25, 2021
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-4.0 in PR #9565 |
ti-chi-bot
pushed a commit
that referenced
this pull request
Jan 28, 2021
…ings connect to one region (#9515) (#9565) cherry-pick #9515 to release-4.0 You can switch your code base to this Pull Request by using [git-extras](https://github.com/tj/git-extras): ```bash # In tikv repo: git pr #9565 ``` After apply modifications, you can push your change to this PR via: ```bash git push [email protected]:ti-srebot/tikv.git pr/9565:release-4.0-927e36f952f8 ``` --- <!-- Thank you for contributing to TiKV! If you haven't already, please read TiKV's [CONTRIBUTING](https://github.com/tikv/tikv/blob/master/CONTRIBUTING.md) document. If you're unsure about anything, just ask; somebody should be along to answer within a day or two. PR Title Format: 1. module [, module2, module3]: what's changed 2. *: what's changed If you want to open the **Challenge Program** pull request, please use the following template: https://raw.githubusercontent.com/tikv/.github/master/.github/PULL_REQUEST_TEMPLATE/challenge-program.md You can use it with query parameters: https://github.com/tikv/tikv/compare/master...${you branch}?template=challenge-program.md --> ### What problem does this PR solve? Problem Summary: When two TiCDC changefeeds connect to the same region, but one changefeed requires old value but the other doesn't, the one that doesn't need old value still receives old value. ### What is changed and how it works? What's Changed: Now we record the old value setting in each `Downstream` and filters the old value appropriately before sinking the events. ### Related changes - Need to cherry-pick to the release branch ### Check List <!--REMOVE the items that are not applicable--> Tests <!-- At least one of them must be included. --> - Unit test ### Release note <!-- bugfixes or new feature need a release note --> - Fix old value config glitch when changefeeds with different settings connect to one region
gengliqi
pushed a commit
to gengliqi/tikv
that referenced
this pull request
Feb 20, 2021
…ings connect to one region (tikv#9515) (tikv#9565) cherry-pick tikv#9515 to release-4.0 You can switch your code base to this Pull Request by using [git-extras](https://github.com/tj/git-extras): ```bash # In tikv repo: git pr tikv#9565 ``` After apply modifications, you can push your change to this PR via: ```bash git push [email protected]:ti-srebot/tikv.git pr/9565:release-4.0-927e36f952f8 ``` --- <!-- Thank you for contributing to TiKV! If you haven't already, please read TiKV's [CONTRIBUTING](https://github.com/tikv/tikv/blob/master/CONTRIBUTING.md) document. If you're unsure about anything, just ask; somebody should be along to answer within a day or two. PR Title Format: 1. module [, module2, module3]: what's changed 2. *: what's changed If you want to open the **Challenge Program** pull request, please use the following template: https://raw.githubusercontent.com/tikv/.github/master/.github/PULL_REQUEST_TEMPLATE/challenge-program.md You can use it with query parameters: https://github.com/tikv/tikv/compare/master...${you branch}?template=challenge-program.md --> ### What problem does this PR solve? Problem Summary: When two TiCDC changefeeds connect to the same region, but one changefeed requires old value but the other doesn't, the one that doesn't need old value still receives old value. ### What is changed and how it works? What's Changed: Now we record the old value setting in each `Downstream` and filters the old value appropriately before sinking the events. ### Related changes - Need to cherry-pick to the release branch ### Check List <!--REMOVE the items that are not applicable--> Tests <!-- At least one of them must be included. --> - Unit test ### Release note <!-- bugfixes or new feature need a release note --> - Fix old value config glitch when changefeeds with different settings connect to one region
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
When two TiCDC changefeeds connect to the same region, but one changefeed requires old value but the other doesn't, the one that doesn't need old value still receives old value.
What is changed and how it works?
What's Changed: Now we record the old value setting in each
Downstreamand filters the old value appropriately before sinking the events.Related changes
Check List
Tests
Release note