refactor progress set to etcd/raft style #318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: qupeng <[email protected]>
hicqu
force-pushed
the
progress-set-refactor
branch
from
c5067b4 to
fe07882
Compare
Hoverbear
reviewed
Nov 7, 2019
Hoverbear
reviewed
Nov 7, 2019
Hoverbear
reviewed
Nov 8, 2019
src/progress/progress_set.rs
Outdated
| Self::from(conf_state.clone()) | ||
| } | ||
|
|
||
| // Test the configuration is valid or not. It's invalid when |
There was a problem hiding this comment.
I suggest you use /// for better IDE support
Signed-off-by: qupeng <[email protected]>
|
What's the progress of this? It looks like this has been paused for a long time |
|
Joint consensus is fully implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's extracted from #317 , only refactor
ProgressSetin this PR, so it should be more easily to review.Signed-off-by: qupeng [email protected]