Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syncer: exit watch leader immediately (#8824) #8831

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8824

What problem does this PR solve?

Issue Number: Close #8823

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Nov 20, 2024
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Nov 20, 2024
Signed-off-by: Ryan Leung <[email protected]>
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.47%. Comparing base (3994172) to head (211d06c).
Report is 2 commits behind head on release-8.5.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-8.5    #8831      +/-   ##
===============================================
- Coverage        75.59%   75.47%   -0.13%     
===============================================
  Files              461      462       +1     
  Lines            72296    72332      +36     
===============================================
- Hits             54655    54595      -60     
- Misses           14140    14223      +83     
- Partials          3501     3514      +13     
Flag Coverage Δ
unittests 75.47% <89.47%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Nov 21, 2024
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 6, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 6, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 6, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 6, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 6, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-06 03:07:37.443305194 +0000 UTC m=+1383445.062959710: ☑️ agreed by lhy1024.
  • 2024-12-06 04:32:51.251135182 +0000 UTC m=+1388558.870789697: ☑️ agreed by JmPotato.

@ti-chi-bot ti-chi-bot bot merged commit c0daa90 into tikv:release-8.5 Dec 6, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants