Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syncer: exit watch leader immediately #8824

Merged
merged 4 commits into from
Nov 20, 2024
Merged

syncer: exit watch leader immediately #8824

merged 4 commits into from
Nov 20, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Nov 19, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #8823

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-linked-issue do-not-merge/needs-triage-completed dco-signoff: yes Indicates the PR's author has signed the dco. labels Nov 19, 2024
@rleungx rleungx requested review from JmPotato and nolouch November 19, 2024 07:40
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Nov 19, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 19, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 19, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-19 08:11:01.688969268 +0000 UTC m=+948623.879838249: ☑️ agreed by JmPotato.
  • 2024-11-19 08:50:57.572533724 +0000 UTC m=+951019.763402721: ☑️ agreed by nolouch.

@JmPotato
Copy link
Member

/retest

@codecov Codecov
Copy link

codecov bot commented Nov 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.26%. Comparing base (76e3b43) to head (0e396cf).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8824      +/-   ##
==========================================
+ Coverage   75.24%   75.26%   +0.01%     
==========================================
  Files         456      456              
  Lines       71608    71616       +8     
==========================================
+ Hits        53884    53902      +18     
+ Misses      14295    14278      -17     
- Partials     3429     3436       +7
Flag Coverage Δ
unittests 75.26% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. and removed do-not-merge/needs-triage-completed labels Nov 20, 2024
@rleungx
add debug log
0903d7c 
Signed-off-by: Ryan Leung <[email protected]>
@rleungx
Copy link
Member Author

rleungx commented Nov 20, 2024

/hold

@rleungx
remove log
745ba97 
Signed-off-by: Ryan Leung <[email protected]>
@rleungx
add log
0e396cf 
Signed-off-by: Ryan Leung <[email protected]>
@rleungx
Copy link
Member Author

rleungx commented Nov 20, 2024

/hold cancel

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2024
@ti-chi-bot ti-chi-bot bot merged commit 41ec8dc into tikv:master Nov 20, 2024
25 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Nov 20, 2024
@rleungx @ti-chi-bot
This is an automated cherry-pick of tikv#8824
3eb080e 
close tikv#8823

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #8827.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 20, 2024
Open
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Nov 20, 2024
@rleungx @ti-chi-bot
This is an automated cherry-pick of tikv#8824
c4787b1 
close tikv#8823

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #8828.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 20, 2024
Open
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Nov 20, 2024
@rleungx @ti-chi-bot
This is an automated cherry-pick of tikv#8824
031374e 
close tikv#8823

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #8829.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 20, 2024
Merged
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Nov 20, 2024
@rleungx @ti-chi-bot
This is an automated cherry-pick of tikv#8824
0a1eda9 
close tikv#8823

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #8830.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 20, 2024
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #8831.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 20, 2024
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #8832.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Nov 20, 2024
@rleungx @ti-chi-bot
This is an automated cherry-pick of tikv#8824
6517e52 
close tikv#8823

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 20, 2024
Open
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Nov 20, 2024
@rleungx @ti-chi-bot
This is an automated cherry-pick of tikv#8824
3bd392e 
close tikv#8823

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #8834.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 20, 2024
Open
@rleungx rleungx deleted the exit-immediately branch November 21, 2024 08:10
ti-chi-bot bot pushed a commit that referenced this pull request Dec 3, 2024
@ti-chi-bot @rleungx
syncer: exit watch leader immediately (#8824) (#8829)
1d71414 
close #8823

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: Ryan Leung <[email protected]>
ti-chi-bot bot added a commit that referenced this pull request Dec 6, 2024
@ti-chi-bot @rleungx @ti-chi-bot
syncer: exit watch leader immediately (#8824) (#8831)
c0daa90 
close #8823

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: Ryan Leung <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
ti-chi-bot bot added a commit that referenced this pull request Dec 11, 2024
@ti-chi-bot @rleungx @ti-chi-bot
syncer: exit watch leader immediately (#8824) (#8830)
ec3892a 
close #8823

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: Ryan Leung <[email protected]>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@JmPotato JmPotato JmPotato approved these changes

Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The watch leader loop should exit ASAP when etcd leader changes
4 participants
@rleungx @JmPotato @ti-chi-bot @nolouch