Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dr: fix store learner check #7223

Closed
wants to merge 3 commits into from
Closed

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Oct 18, 2023

What problem does this PR solve?

Issue Number: Close #7218

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 18, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 18, 2023
@lhy1024 lhy1024 requested review from disksing and nolouch and removed request for disksing October 18, 2023 05:42
@ti-chi-bot ti-chi-bot bot requested review from disksing and HunDunDM October 18, 2023 05:42
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 18, 2023
@lhy1024 lhy1024 removed the request for review from HunDunDM October 18, 2023 05:42
Signed-off-by: lhy1024 <[email protected]>
Signed-off-by: lhy1024 <[email protected]>
@lhy1024
Copy link
Contributor Author

lhy1024 commented Oct 18, 2023

it is duplicated with #7222

@lhy1024 lhy1024 closed this Oct 18, 2023
@lhy1024 lhy1024 deleted the fix-dr-auto-sync branch October 18, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dr: cannot add new stores in primary
1 participant