Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dr: cannot add new stores in primary #7218

Closed
lhy1024 opened this issue Oct 17, 2023 · 2 comments
Closed

dr: cannot add new stores in primary #7218

lhy1024 opened this issue Oct 17, 2023 · 2 comments
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. report/customer Customers have encountered this bug. type/bug The issue is confirmed as a bug.

Comments

@lhy1024
Copy link
Contributor

lhy1024 commented Oct 17, 2023

Bug Report

What did you do?

test dr-auto-sync

  1. down dr
  2. add new stores in primary

What did you expect to see?

tikv can add new peers in new stores

What did you see instead?

tikv cannot add new peers and log print "drop msg"

What version of PD are you using (pd-server -V)?

v6.5.4

@lhy1024 lhy1024 added the type/bug The issue is confirmed as a bug. label Oct 17, 2023
@lhy1024
Copy link
Contributor Author

lhy1024 commented Oct 17, 2023

if s.GetRegionCount() == s.GetLearnerCount() {
continue
}

For new stores, if its learner count is equal to the region count, the code will not put it into AvailableStores, so tikv will drop msg.

Unfortunately, all peers in the new store are learners, which is normal.

Workaround: switch majority mode

@seiya-annie
Copy link

/found customer

@ti-chi-bot ti-chi-bot bot added the report/customer Customers have encountered this bug. label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. report/customer Customers have encountered this bug. type/bug The issue is confirmed as a bug.
Projects
Development

Successfully merging a pull request may close this issue.

3 participants