Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: check raftcluster nil (#7054) #7067

Closed
wants to merge 1 commit into from
Closed

*: check raftcluster nil (#7054) #7067

wants to merge 1 commit into from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7054

What problem does this PR solve?

Issue Number: Close #7053

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 11, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-5.3 The PR belongs to release-5.3 cherry pick. labels Sep 11, 2023
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Sep 11, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 11, 2023
Merged
@ti-chi-bot ti-chi-bot bot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 11, 2023
@ti-chi-bot ti-chi-bot bot requested review from disksing and rleungx September 11, 2023 07:43
@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 11, 2023
@HuSharp
fix
766d908 
Signed-off-by: husharp <[email protected]>
@HuSharp HuSharp force-pushed the cherry-pick-7054-to-release-5.3 branch from 8b1e141 to 766d908 Compare September 13, 2023 05:35
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 13, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 13, 2023
@nolouch
Copy link
Contributor

nolouch commented Sep 18, 2023

/test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 18, 2023

@nolouch: No presubmit jobs available for tikv/[email protected]

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 18, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 18, 2023
@nolouch
Copy link
Contributor

nolouch commented Sep 26, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 26, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 26, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 766d908

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 26, 2023
@nolouch
Copy link
Contributor

nolouch commented Sep 30, 2023

/test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 30, 2023

@nolouch: No presubmit jobs available for tikv/[email protected]

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rleungx
Copy link
Member

rleungx commented Oct 8, 2023

/test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 8, 2023

@rleungx: No presubmit jobs available for tikv/[email protected]

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rleungx
Copy link
Member

rleungx commented Oct 8, 2023

/run-all-tests

@ti-chi-bot ti-chi-bot closed this Dec 1, 2023
@ti-chi-bot
Copy link
Member Author

This pull request is closed because its related version has closed automatic cherry-picking.
If it's still needed, you can reopen it or just regenerate it using bot,
see:

https://prow.tidb.net/command-help#cherrypick
https://book.prow.tidb.net/#/plugins/cherrypicker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disksing disksing disksing approved these changes

@nolouch nolouch nolouch approved these changes

@rleungx rleungx Awaiting requested review from rleungx

Assignees

@HuSharp HuSharp

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.3 The PR belongs to release-5.3 cherry pick.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @nolouch @rleungx @disksing @HuSharp