-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: check raftcluster nil #7054
*: check raftcluster nil #7054
Conversation
Signed-off-by: husharp <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #7054 +/- ##
==========================================
- Coverage 74.41% 74.36% -0.05%
==========================================
Files 436 436
Lines 46440 46460 +20
==========================================
- Hits 34558 34552 -6
- Misses 8858 8874 +16
- Partials 3024 3034 +10
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add some tests? Which branches do we need to pick?
I think it need to pick to the branch which we supported |
Signed-off-by: husharp <[email protected]>
After reviewing the code, I found that there is a middleware that checks |
Maybe you need to use getCluster(r)? |
Signed-off-by: husharp <[email protected]>
get it |
/merge |
@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 2f5117e
|
@HuSharp: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
In response to a cherrypick label: new pull request created to branch |
close tikv#7053 Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
close tikv#7053 Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
close tikv#7053 Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
close tikv#7053 Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
close tikv#7053 Signed-off-by: ti-chi-bot <[email protected]>
close #7053 Signed-off-by: husharp <[email protected]> Co-authored-by: husharp <[email protected]>
close #7053 Signed-off-by: husharp <[email protected]> Co-authored-by: husharp <[email protected]>
close #7053 Signed-off-by: husharp <[email protected]> Co-authored-by: husharp <[email protected]>
close #7053 Signed-off-by: husharp <[email protected]> Co-authored-by: husharp <[email protected]> Co-authored-by: Hu# <[email protected]>
What problem does this PR solve?
Issue Number: Close #7053
What is changed and how does it work?
Check List
Tests
Release note