*: reduce WithLabelValues of prometheus #5802

lhy1024 · 2022-12-26T18:15:39Z

Signed-off-by: lhy1024 [email protected]

What problem does this PR solve?

Issue Number: Close #5801

What is changed and how does it work?

Check List

Tests

Unit test

Release note

None.

Signed-off-by: lhy1024 <[email protected]>

ti-chi-bot · 2022-12-26T18:15:40Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

nolouch
rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

codecov · 2022-12-26T18:22:18Z

Codecov Report

Base: 75.55% // Head: 75.56% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (aedc8ef) compared to base (ba81088).
Patch coverage: 70.56% of modified lines in pull request are covered.

❗ Current head aedc8ef differs from pull request most recent head 42e0030. Consider uploading reports for the commit 42e0030 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5802      +/-   ##
==========================================
+ Coverage   75.55%   75.56%   +0.01%     
==========================================
  Files         338      338              
  Lines       33621    33626       +5     
==========================================
+ Hits        25401    25409       +8     
+ Misses       6037     6034       -3     
  Partials     2183     2183

Flag	Coverage Δ
unittests	`75.56% <70.56%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/metrics.go	`100.00% <ø> (ø)`
server/schedule/checker/learner_checker.go	`72.72% <0.00%> (ø)`
server/schedule/filter/filters.go	`87.95% <ø> (ø)`
server/schedule/hbstream/metric.go	`100.00% <ø> (ø)`
server/schedule/metrics.go	`100.00% <ø> (ø)`
server/schedulers/metrics.go	`100.00% <ø> (ø)`
server/schedulers/utils.go	`89.67% <ø> (ø)`
server/statistics/store_collection.go	`93.75% <ø> (ø)`
server/statistics/store_hot_peers_infos.go	`93.65% <ø> (ø)`
server/tso/metrics.go	`100.00% <ø> (ø)`
... and 68 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: lhy1024 <[email protected]>

Signed-off-by: lhy1024 <[email protected]> Conflicts: server/schedule/checker/rule_checker.go

Signed-off-by: lhy1024 <[email protected]>

nolouch

great works, rest lgtm.

tools/pd-simulator/simulator/task.go

nolouch · 2023-01-09T03:11:47Z

server/schedule/checker/replica_checker.go

@@ -30,11 +30,27 @@ import (

 const (
 	replicaCheckerName = "replica-checker"
+	replicaChecker     = "replica_checker"


in line 38~53

replicaCheckerName and replicaChecker, can we just keep one? I think the metrics are not a big compatibility issue.

There are some similar problems with other schedulers and checkers. I think we can unify them in other pr.

Signed-off-by: lhy1024 <[email protected]>

rleungx

Overall LGTM, except for the unresolved comment.

lhy1024 · 2023-01-10T06:52:46Z

Overall LGTM, except for the unresolved comment.

It will do in #5845

nolouch · 2023-01-10T07:33:17Z

/merge

ti-chi-bot · 2023-01-10T07:33:19Z

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-01-10T07:33:20Z

This pull request has been accepted and is ready to merge.

Commit hash: aedc8ef

ti-chi-bot · 2023-01-10T07:33:33Z

@lhy1024: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: lhy1024 <[email protected]>

lhy1024 · 2023-01-10T07:40:21Z

/merge

ti-chi-bot · 2023-01-10T07:40:23Z

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-01-10T07:40:24Z

This pull request has been accepted and is ready to merge.

Commit hash: 42e0030

*: reduce WithLabelValues of prometheus

d91c823

Signed-off-by: lhy1024 <[email protected]>

ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 26, 2022

ti-chi-bot requested review from disksing and Yisaer December 26, 2022 18:15

fix lint

73b49a1

Signed-off-by: lhy1024 <[email protected]>

lhy1024 added type/enhancement The issue or PR belongs to an enhancement. component/metrics Metrics. labels Dec 26, 2022

ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 31, 2022

Merge branch 'master' of http://github.com/tikv/pd into promethues

767cbe0

Signed-off-by: lhy1024 <[email protected]> Conflicts: server/schedule/checker/rule_checker.go

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2023

fix conflict

88982d6

Signed-off-by: lhy1024 <[email protected]>

nolouch reviewed Jan 9, 2023

View reviewed changes

address comments

aedc8ef

Signed-off-by: lhy1024 <[email protected]>

rleungx reviewed Jan 10, 2023

View reviewed changes

nolouch approved these changes Jan 10, 2023

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 10, 2023

rleungx approved these changes Jan 10, 2023

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 10, 2023

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 10, 2023

Merge branch 'master' into promethues

f1f4a0b

lhy1024 added 2 commits January 10, 2023 15:38

move comments

b826ddc

Signed-off-by: lhy1024 <[email protected]>

Merge branch 'promethues' of github.com:lhy1024/pd into promethues

42e0030

ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jan 10, 2023

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 10, 2023

ti-chi-bot merged commit 275c43e into tikv:master Jan 10, 2023

lhy1024 deleted the promethues branch January 10, 2023 07:55

rleungx mentioned this pull request Apr 23, 2023

Region Health panel missing data if PD suffers from leader transfer #6366

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: reduce WithLabelValues of prometheus #5802

*: reduce WithLabelValues of prometheus #5802

lhy1024 commented Dec 26, 2022

ti-chi-bot commented Dec 26, 2022 •

edited

Loading

codecov bot commented Dec 26, 2022 •

edited

Loading

nolouch left a comment

nolouch Jan 9, 2023

lhy1024 Jan 9, 2023

nolouch Jan 9, 2023

lhy1024 Jan 10, 2023 •

edited

Loading

rleungx left a comment

lhy1024 commented Jan 10, 2023

nolouch commented Jan 10, 2023

ti-chi-bot commented Jan 10, 2023

ti-chi-bot commented Jan 10, 2023

ti-chi-bot commented Jan 10, 2023

lhy1024 commented Jan 10, 2023

ti-chi-bot commented Jan 10, 2023

ti-chi-bot commented Jan 10, 2023

*: reduce WithLabelValues of prometheus #5802

*: reduce WithLabelValues of prometheus #5802

Conversation

lhy1024 commented Dec 26, 2022

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot commented Dec 26, 2022 • edited Loading

codecov bot commented Dec 26, 2022 • edited Loading

Codecov Report

nolouch left a comment

Choose a reason for hiding this comment

nolouch Jan 9, 2023

Choose a reason for hiding this comment

lhy1024 Jan 9, 2023

Choose a reason for hiding this comment

nolouch Jan 9, 2023

Choose a reason for hiding this comment

lhy1024 Jan 10, 2023 • edited Loading

Choose a reason for hiding this comment

rleungx left a comment

Choose a reason for hiding this comment

lhy1024 commented Jan 10, 2023

nolouch commented Jan 10, 2023

ti-chi-bot commented Jan 10, 2023

ti-chi-bot commented Jan 10, 2023

ti-chi-bot commented Jan 10, 2023

lhy1024 commented Jan 10, 2023

ti-chi-bot commented Jan 10, 2023

ti-chi-bot commented Jan 10, 2023

ti-chi-bot commented Dec 26, 2022 •

edited

Loading

codecov bot commented Dec 26, 2022 •

edited

Loading

lhy1024 Jan 10, 2023 •

edited

Loading