Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: unify '-' and '_' in schedulers and checkers #5845

Closed
lhy1024 opened this issue Jan 10, 2023 · 4 comments
Closed

metrics: unify '-' and '_' in schedulers and checkers #5845

lhy1024 opened this issue Jan 10, 2023 · 4 comments
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@lhy1024
Copy link
Contributor

lhy1024 commented Jan 10, 2023

Enhancement Task

There are mixed '-' and '_' in schedulers and checkers

replicaCheckerName = "replica-checker"
replicaChecker     = "replica_checker"
@lhy1024 lhy1024 added the type/enhancement The issue or PR belongs to an enhancement. label Jan 10, 2023
@lhy1024
Copy link
Contributor Author

lhy1024 commented Jan 10, 2023

how about unified with '_'? @nolouch @rleungx

@lhy1024 lhy1024 mentioned this issue Jan 10, 2023
Merged
@nolouch
Copy link
Contributor

nolouch commented Jan 10, 2023

lgtm

@okJiang okJiang mentioned this issue Jun 21, 2024
Closed
@okJiang
Copy link
Member

okJiang commented Jul 9, 2024 •
edited
Loading

According to the conclusion in this issue, this issue can be closed.

For monitoring, it will be used as a filter rule_checker/replica_checker/merge_checker , temporarily converted from xxxx-checker to xxxx_checker when needed to maintain user experience compatibility. If it is determined that there is no compatibility problem, then change it

@okJiang
Copy link
Member

okJiang commented Jul 9, 2024

Please help to close the issue~ cc @rleungx @lhy1024

@lhy1024 lhy1024 closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nolouch @lhy1024 @okJiang