Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: clean up the surrounding code of check pkg #5225

Merged
merged 2 commits into from
Jun 24, 2022
Merged

*: clean up the surrounding code of check pkg #5225

merged 2 commits into from
Jun 24, 2022

Conversation

JmPotato
Copy link
Member

Signed-off-by: JmPotato [email protected]

What problem does this PR solve?

Issue Number: close #5105, ref #4813.

What is changed and how does it work?

Clean up the surrounding code of check pkg.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato added the component/testing CI testing. label Jun 24, 2022
@JmPotato JmPotato requested review from lhy1024 and rleungx June 24, 2022 02:38
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 24, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 24, 2022
@disksing disksing added the require-LGT1 Indicates that the PR requires an LGTM. label Jun 24, 2022
@disksing
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 02de74f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 24, 2022
@codecov
Copy link

codecov bot commented Jun 24, 2022 •
edited
Loading

Codecov Report

Merging #5225 (349bcd6) into master (e0084c5) will increase coverage by 0.19%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master    #5225      +/-   ##
==========================================
+ Coverage   75.53%   75.72%   +0.19%     
==========================================
  Files         310      310              
  Lines       30684    30674      -10     
==========================================
+ Hits        23176    23227      +51     
+ Misses       5511     5460      -51     
+ Partials     1997     1987      -10
Flag Coverage Δ
unittests 75.72% <87.50%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/testutil/testutil.go 72.72% <75.00%> (ø)
pkg/testutil/testutil.go 100.00% <100.00%> (+33.33%) ⬆️
pkg/errs/errs.go 75.00% <0.00%> (-25.00%) ⬇️
...erver/config/service_middleware_persist_options.go 91.66% <0.00%> (-8.34%) ⬇️
server/member/member.go 62.10% <0.00%> (-5.27%) ⬇️
server/schedule/labeler/rules.go 87.50% <0.00%> (-2.28%) ⬇️
server/region_syncer/client.go 85.82% <0.00%> (-2.24%) ⬇️
tools/pd-ctl/pdctl/command/operator.go 66.66% <0.00%> (-1.15%) ⬇️
server/schedule/operator_controller.go 85.77% <0.00%> (-0.81%) ⬇️
server/handler.go 52.58% <0.00%> (-0.39%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0084c5...349bcd6. Read the comment docs.

bufferflies
bufferflies reviewed Jun 24, 2022
View reviewed changes
pkg/testutil/testutil.go
defaultWaitRetryTimes = 200
defaultSleepInterval = time.Millisecond * 100
defaultWaitFor = time.Second * 20
defaultWaitFor = time.Second * 20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why repeat it? The similar code may be found in /client/testutil.go.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to prevent the client module from relying on the PD module.

@ti-chi-bot
Copy link
Member

@JmPotato: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@JmPotato JmPotato added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 24, 2022
@JmPotato JmPotato removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2022
@JmPotato
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 349bcd6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 24, 2022
@ti-chi-bot ti-chi-bot merged commit 5dc97f8 into tikv:master Jun 24, 2022
@JmPotato JmPotato deleted the clen_up_checker branch June 24, 2022 03:30
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this pull request Jul 14, 2022
@JmPotato @CabinfeverB
*: clean up the surrounding code of check pkg (tikv#5225)
1c26652 
ref tikv#4813, close tikv#5105

Clean up the surrounding code of check pkg.

Signed-off-by: JmPotato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bufferflies bufferflies bufferflies left review comments

@disksing disksing disksing approved these changes

@lhy1024 lhy1024 Awaiting requested review from lhy1024

@rleungx rleungx Awaiting requested review from rleungx

Assignees
No one assigned
Labels
component/testing CI testing. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use require.Eventually to replace testutil.WaitUntil
4 participants
@JmPotato @ti-chi-bot @disksing @bufferflies