Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use require.Eventually to replace testutil.WaitUntil #5105

Closed
Tracked by #4813
JmPotato opened this issue Jun 6, 2022 · 0 comments · Fixed by #5225
Closed
Tracked by #4813

Use require.Eventually to replace testutil.WaitUntil #5105

JmPotato opened this issue Jun 6, 2022 · 0 comments · Fixed by #5225
Labels
component/testing CI testing. type/enhancement The issue or PR belongs to an enhancement.

Comments

@JmPotato
Copy link
Member

JmPotato commented Jun 6, 2022

Enhancement Task

We can use require.Eventually to replace the testutil.WaitUntil function we made ourselves.
@JmPotato JmPotato added type/enhancement The issue or PR belongs to an enhancement. component/testing CI testing. labels Jun 6, 2022
This was referenced Jun 6, 2022
Closed
Merged
ti-chi-bot added a commit that referenced this issue Jun 7, 2022
@JmPotato @ti-chi-bot
*: use testutil.Eventually to replace testutil.WaitUntil (#5108)
147e9c0 
ref #5105

Use testutil.Eventually to replace testutil.WaitUntil.

Signed-off-by: JmPotato <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
@JmPotato JmPotato mentioned this issue Jun 24, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue Jun 24, 2022
@JmPotato
*: clean up the surrounding code of check pkg (#5225)
5dc97f8 
ref #4813, close #5105

Clean up the surrounding code of check pkg.

Signed-off-by: JmPotato <[email protected]>
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this issue Jul 14, 2022
@JmPotato @ti-chi-bot @CabinfeverB
*: use testutil.Eventually to replace testutil.WaitUntil (tikv#5108)
dcf14ef 
ref tikv#5105

Use testutil.Eventually to replace testutil.WaitUntil.

Signed-off-by: JmPotato <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
CabinfeverB pushed a commit to CabinfeverB/pd that referenced this issue Jul 14, 2022
@JmPotato @CabinfeverB
*: clean up the surrounding code of check pkg (tikv#5225)
1c26652 
ref tikv#4813, close tikv#5105

Clean up the surrounding code of check pkg.

Signed-off-by: JmPotato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/testing CI testing. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: clean up the surrounding code of check pkg JmPotato/pd
1 participant
@JmPotato