Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: change scoreV2 to adapt the higher disk capacity and amp . (#4837) #4847

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4837

Signed-off-by: bufferflies [email protected]

What problem does this PR solve?

Issue Number: Close #4805

What is changed and how it works?

if the biggest store's capacity is more than 2T , the store's score may be closed to the up score as b(1e7). so the smallest store will not be balanced even if they has less available capacity.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note

None.

Signed-off-by: bufferflies <[email protected]>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Apr 26, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #4847 (a615d30) into release-5.3 (bea87ac) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           release-5.3    #4847      +/-   ##
===============================================
- Coverage        74.93%   74.90%   -0.04%     
===============================================
  Files              263      263              
  Lines            27341    27341              
===============================================
- Hits             20489    20480       -9     
- Misses            5040     5044       +4     
- Partials          1812     1817       +5     
Flag Coverage Δ
unittests 74.90% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/core/test_util.go 83.20% <ø> (ø)
server/core/store.go 81.57% <100.00%> (ø)
server/schedulers/shuffle_hot_region.go 55.55% <0.00%> (-10.11%) ⬇️
server/tso/local_allocator.go 71.62% <0.00%> (-6.76%) ⬇️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
server/server.go 70.96% <0.00%> (-1.93%) ⬇️
pkg/btree/btree.go 85.78% <0.00%> (-0.97%) ⬇️
server/encryptionkm/key_manager.go 72.80% <0.00%> (-0.80%) ⬇️
server/core/storage.go 68.79% <0.00%> (-0.76%) ⬇️
server/cluster/cluster.go 82.46% <0.00%> (-0.47%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bea87ac...a615d30. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 27, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 5, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 27, 2022
@nolouch
Copy link
Contributor

nolouch commented May 27, 2022

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: b56b74c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2022
@ti-chi-bot ti-chi-bot merged commit 0373b3b into tikv:release-5.3 May 30, 2022
@purelind purelind added this to the v5.3.2 milestone Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.3 The PR belongs to release-5.3 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants