Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: change scoreV2 to adapt the higher disk capacity and amp . #4837

Merged
merged 1 commit into from
Apr 24, 2022

Conversation

bufferflies
Copy link
Contributor

Signed-off-by: bufferflies [email protected]

What problem does this PR solve?

Issue Number: Close #4805

What is changed and how it works?

if the biggest store's capacity is more than 2T , the store's score may be closed to the up score as b(1e7). so the smallest store will not be balanced even if they has less available capacity.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note

None.

Signed-off-by: bufferflies <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 22, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.0 The PR needs to cherry pick to release-6.0 branch. release-note-none Denotes a PR that doesn't merit a release note. labels Apr 22, 2022
@ti-chi-bot ti-chi-bot requested review from disksing and rleungx April 22, 2022 09:55
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #4837 (1a036db) into master (1885540) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4837   +/-   ##
=======================================
  Coverage   75.34%   75.34%           
=======================================
  Files         295      295           
  Lines       28810    28810           
=======================================
+ Hits        21706    21708    +2     
+ Misses       5186     5181    -5     
- Partials     1918     1921    +3     
Flag Coverage Δ
unittests 75.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/core/test_util.go 83.20% <ø> (ø)
server/core/store.go 81.68% <100.00%> (ø)
server/storage/kv/etcd_kv.go 69.56% <0.00%> (-10.15%) ⬇️
pkg/dashboard/adapter/manager.go 78.72% <0.00%> (-4.26%) ⬇️
server/tso/tso.go 61.14% <0.00%> (-4.00%) ⬇️
server/schedule/operator_controller.go 85.65% <0.00%> (-0.81%) ⬇️
server/config/persist_options.go 92.91% <0.00%> (-0.75%) ⬇️
server/server.go 75.00% <0.00%> (-0.47%) ⬇️
server/grpc_service.go 54.22% <0.00%> (-0.36%) ⬇️
server/schedulers/hot_region.go 83.08% <0.00%> (-0.31%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1885540...1a036db. Read the comment docs.

Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and we need some regression tests to ensure it works better.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 24, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 24, 2022
@disksing
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1a036db

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 24, 2022
@ti-chi-bot ti-chi-bot merged commit 6cb4b27 into tikv:master Apr 24, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4838.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4847.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4848.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4849.

ti-chi-bot added a commit that referenced this pull request Apr 26, 2022
ti-chi-bot added a commit that referenced this pull request May 30, 2022
ti-chi-bot added a commit that referenced this pull request Jul 18, 2022
@bufferflies bufferflies added the needs-cherry-pick-release-5.1 Type: Need cherry pick to release-5.1 label Dec 8, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5769.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Dec 8, 2022
ti-chi-bot added a commit that referenced this pull request Dec 9, 2022
…) (#5769)

close #4805, ref #4837

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: bufferflies <[email protected]>

Co-authored-by: buffer <[email protected]>
Co-authored-by: bufferflies <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.1 Type: Need cherry pick to release-5.1 needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 The PR needs to cherry pick to release-6.0 branch. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No balance operator even one disk is full
4 participants