-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: change scoreV2 to adapt the higher disk capacity and amp . #4837
Conversation
Signed-off-by: bufferflies <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
42bfb36
to
1a036db
Compare
Codecov Report
@@ Coverage Diff @@
## master #4837 +/- ##
=======================================
Coverage 75.34% 75.34%
=======================================
Files 295 295
Lines 28810 28810
=======================================
+ Hits 21706 21708 +2
+ Misses 5186 5181 -5
- Partials 1918 1921 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and we need some regression tests to ensure it works better.
/merge |
@disksing: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 1a036db
|
In response to a cherrypick label: new pull request created: #4838. |
In response to a cherrypick label: new pull request created: #4847. |
In response to a cherrypick label: new pull request created: #4848. |
In response to a cherrypick label: new pull request created: #4849. |
…) (#4849) close #4805, ref #4837 Signed-off-by: bufferflies <[email protected]> Co-authored-by: bufferflies <[email protected]>
…) (#4847) close #4805, ref #4837 Signed-off-by: bufferflies <[email protected]> Co-authored-by: bufferflies <[email protected]>
…) (#4848) close #4805, ref #4837 Signed-off-by: bufferflies <[email protected]> Co-authored-by: bufferflies <[email protected]>
In response to a cherrypick label: new pull request created: #5769. |
close tikv#4805 Signed-off-by: ti-chi-bot <[email protected]>
…) (#5769) close #4805, ref #4837 Signed-off-by: ti-chi-bot <[email protected]> Signed-off-by: bufferflies <[email protected]> Co-authored-by: buffer <[email protected]> Co-authored-by: bufferflies <[email protected]>
Signed-off-by: bufferflies [email protected]
What problem does this PR solve?
Issue Number: Close #4805
What is changed and how it works?
if the biggest store's capacity is more than 2T , the store's score may be closed to the up score as b(1e7). so the smallest store will not be balanced even if they has less available capacity.
Check List
Tests
Code changes
Side effects
Related changes
Release note