placement: change ValidateStores condition

[CabinfeverB]

Signed-off-by: Cabinfever_B [email protected]

What problem does this PR solve?

Issue Number: Close #4690

What is changed and how it works?

change and to or

change ValidateStores condition

Check List

Tests

• Unit test

Release note

 None.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• lhy1024
• rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[codecov]

Codecov Report

Merging #4700 (3285b6b) into master (e25d403) will increase coverage by 0.02%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master    #4700      +/-   ##
==========================================
+ Coverage   75.05%   75.08%   +0.02%     
==========================================
  Files         283      283              
  Lines       27842    27849       +7     
==========================================
+ Hits        20898    20910      +12     
+ Misses       5080     5076       -4     
+ Partials     1864     1863       -1     

Flag	Coverage Δ
unittests	75.08% <85.71%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
client/client.go	68.89% <0.00%> (+0.10%)	⬆️
server/cluster/prepare_checker.go	90.00% <0.00%> (ø)
server/handler.go	51.22% <0.00%> (-0.41%)	⬇️
server/schedulers/evict_slow_store.go	53.33% <33.33%> (ø)
server/cluster/unsafe_recovery_controller.go	79.86% <50.00%> (ø)
server/schedule/checker/rule_checker.go	78.97% <50.00%> (ø)
pkg/autoscaling/calculation.go	58.41% <100.00%> (ø)
server/api/store.go	65.24% <100.00%> (ø)
server/cluster/cluster.go	84.91% <100.00%> (ø)
server/core/store.go	81.34% <100.00%> (+0.14%)	⬆️
... and 33 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b0cafb...3285b6b. Read the comment docs.

[lhy1024]

Do we need to add a test to avoid similar code?

[CabinfeverB]

Do we need to add a test to avoid similar code?

I don't think it's easy to avoid similar code with additional tests. It's good behavior that when creating stores, try to add heartbeat information

[rleungx]

/merge

[ti-chi-bot]

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 32023ef