Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flawed judgment conditions when validating stores in rule checker #4690

Closed
CabinfeverB opened this issue Mar 2, 2022 · 1 comment · Fixed by #4700
Closed

Flawed judgment conditions when validating stores in rule checker #4690

CabinfeverB opened this issue Mar 2, 2022 · 1 comment · Fixed by #4700
Assignees
@CabinfeverB
Labels
type/bug The issue is confirmed as a bug.

Comments

@CabinfeverB
Copy link
Member

Bug Report

There is a problem that has a flawed judgment condition when validating stores in rule checker.
If a store is offline or disconnected, it is not in Up state.
image

What version of PD are you using (pd-server -V)?

master
@CabinfeverB CabinfeverB added the type/bug The issue is confirmed as a bug. label Mar 2, 2022
@CabinfeverB
Copy link
Member Author

/assign

@CabinfeverB CabinfeverB reopened this Mar 2, 2022
@CabinfeverB CabinfeverB mentioned this issue Mar 3, 2022
Merged
ti-chi-bot added a commit that referenced this issue Mar 4, 2022
@CabinfeverB @ti-chi-bot
placement: change ValidateStores condition (#4700)
bf2d784 
close #4690

change ValidateStores condition

Signed-off-by: Cabinfever_B <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CabinfeverB CabinfeverB

Labels
type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

placement: change ValidateStores condition CabinfeverB/pd
1 participant
@CabinfeverB