Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replication: check the up stores to switch to async #3991

Merged
merged 2 commits into from
Aug 16, 2021

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Aug 16, 2021

What problem does this PR solve?

Fix #3924

image
start up one zone, and the another zone do not startup.

➜  pd git:(master) curl http://127.0.0.1:30058/pd/api/v1/replication_mode/status
{
  "mode": "dr-auto-sync",
  "dr-auto-sync": {
    "label_key": "",
    "state": "sync",
    "state_id": 4
  }
}

Check List

Tests

  • Unit test

Release note

replication: fix the issue that the state cannot switch to async 

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 16, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 16, 2021
@ti-chi-bot ti-chi-bot requested review from disksing and Yisaer August 16, 2021 07:40
@nolouch nolouch added the needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 label Aug 16, 2021
@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #3991 (914da78) into master (ab0125b) will increase coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3991      +/-   ##
==========================================
+ Coverage   74.57%   74.80%   +0.22%     
==========================================
  Files         250      250              
  Lines       25541    25548       +7     
==========================================
+ Hits        19047    19110      +63     
+ Misses       4801     4761      -40     
+ Partials     1693     1677      -16     
Flag Coverage Δ
unittests 74.80% <100.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/replication/replication_mode.go 78.75% <100.00%> (+0.63%) ⬆️
pkg/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
client/base_client.go 82.29% <0.00%> (-2.61%) ⬇️
server/schedule/operator/step.go 68.43% <0.00%> (-1.33%) ⬇️
server/schedule/operator_controller.go 84.75% <0.00%> (-0.80%) ⬇️
server/grpc_service.go 47.23% <0.00%> (ø)
client/client.go 71.82% <0.00%> (+0.27%) ⬆️
server/member/member.go 66.84% <0.00%> (+0.53%) ⬆️
server/server.go 72.64% <0.00%> (+0.75%) ⬆️
server/core/storage.go 68.44% <0.00%> (+0.76%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab0125b...914da78. Read the comment docs.

@nolouch
Copy link
Contributor Author

nolouch commented Aug 16, 2021

PTAL @disksing @rleungx

@nolouch nolouch requested review from rleungx and removed request for Yisaer August 16, 2021 08:01
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 16, 2021
@nolouch nolouch added the require-LGT1 Indicates that the PR requires an LGTM. label Aug 16, 2021
@nolouch
Copy link
Contributor Author

nolouch commented Aug 16, 2021

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 15e0719

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 16, 2021
@nolouch
Copy link
Contributor Author

nolouch commented Aug 16, 2021

/merge

@ti-chi-bot
Copy link
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3995.

@nolouch nolouch deleted the fix-switch branch August 16, 2021 09:42
ti-chi-bot added a commit that referenced this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.2 Type: Need cherry pick to release-5.2 release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dr-auto-sync will be sync only one zone exsit
4 participants