Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: fix inaccurate statistics and config (#3949) #3964

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #3949

Signed-off-by: HunDunDM [email protected]

What problem does this PR solve?

What is changed and how it works?

  • scheduler: fix inaccurate statistics and config

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

None

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Aug 11, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved priority/P1 The issue has P1 priority. type/cherry-pick-for-release-5.0 The PR belongs to release-5.0 cherry pick. labels Aug 11, 2021
@ti-chi-bot ti-chi-bot requested review from disksing and nolouch August 11, 2021 13:37
@HunDunDM HunDunDM removed the priority/P1 The issue has P1 priority. label Aug 11, 2021
@HunDunDM HunDunDM added this to the v5.0.4 milestone Aug 11, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 13, 2021
@disksing disksing removed their request for review August 24, 2021 03:09
@HunDunDM
Copy link
Member

HunDunDM commented Aug 29, 2021

A small amount of code for #3658 , #3833 , #3921 will be introduced.

@lhy1024 lhy1024 self-requested a review September 1, 2021 04:15
@HunDunDM HunDunDM force-pushed the cherry-pick-3949-to-release-5.0 branch from 4e9019b to 95d566a Compare September 1, 2021 07:24
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 1, 2021
@HunDunDM
Copy link
Member

HunDunDM commented Sep 1, 2021

/rebuild

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 1, 2021
@lhy1024
Copy link
Contributor

lhy1024 commented Sep 1, 2021

/merge

@ti-chi-bot
Copy link
Member Author

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 7132f2a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 1, 2021
Signed-off-by: HunDunDM <[email protected]>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Sep 1, 2021
@HunDunDM
Copy link
Member

HunDunDM commented Sep 1, 2021

/merge

@ti-chi-bot
Copy link
Member Author

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 599f302

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 1, 2021
@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #3964 (43094f7) into release-5.0 (7f6d57e) will decrease coverage by 0.00%.
The diff coverage is 89.58%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-5.0    #3964      +/-   ##
===============================================
- Coverage        74.84%   74.84%   -0.01%     
===============================================
  Files              245      245              
  Lines            24308    24321      +13     
===============================================
+ Hits             18193    18202       +9     
- Misses            4501     4505       +4     
  Partials          1614     1614              
Flag Coverage Δ
unittests 74.84% <89.58%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedule/operator/operator.go 95.93% <71.42%> (-0.62%) ⬇️
server/schedulers/hot_region.go 82.43% <90.00%> (+1.58%) ⬆️
server/schedulers/hot_region_config.go 82.47% <100.00%> (+0.55%) ⬆️
server/schedulers/utils.go 93.67% <100.00%> (-0.24%) ⬇️
server/region_syncer/server.go 83.08% <0.00%> (-5.89%) ⬇️
server/election/leadership.go 83.52% <0.00%> (-3.53%) ⬇️
server/schedule/operator/step.go 66.77% <0.00%> (-2.33%) ⬇️
server/tso/allocator_manager.go 76.74% <0.00%> (-1.83%) ⬇️
client/base_client.go 82.98% <0.00%> (-1.55%) ⬇️
tools/pd-ctl/pdctl/command/operator.go 65.99% <0.00%> (-1.22%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f6d57e...43094f7. Read the comment docs.

@ti-chi-bot ti-chi-bot merged commit b1adc27 into tikv:release-5.0 Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.0 The PR belongs to release-5.0 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants