schedulers: unify the use and GC of hot-region's pendings and regionPendings

[HunDunDM]

Signed-off-by: HunDunDM [email protected]

What problem does this PR solve?

• The current pendings and regionPendings records duplicate data, and they are each useful.
• The current weight attenuation strategy is unreasonable.
• Misuse of CreateTime by the current GC strategy may lead to premature GC.

What is changed and how it works?

• unify the use and GC of hot-region's pendings and regionPendings, no longer related to CreateTime.
• weight is constant at 1.

Check List

Tests

• Unit test

Code changes

Side effects

Related changes

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• lhy1024
• nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[codecov]

Codecov Report

Merging #3921 (319524f) into master (386b044) will increase coverage by 0.16%.
The diff coverage is 91.89%.

❗ Current head 319524f differs from pull request most recent head 286220b. Consider uploading reports for the commit 286220b to get more accurate results

@@            Coverage Diff             @@
##           master    #3921      +/-   ##
==========================================
+ Coverage   74.51%   74.68%   +0.16%     
==========================================
  Files         246      246              
  Lines       25068    25068              
==========================================
+ Hits        18680    18721      +41     
+ Misses       4723     4696      -27     
+ Partials     1665     1651      -14     

Flag	Coverage Δ
unittests	74.68% <91.89%> (+0.16%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/schedulers/utils.go	92.85% <ø> (-0.38%)	⬇️
server/schedulers/hot_region.go	86.83% <91.89%> (+1.05%)	⬆️
server/kv/etcd_kv.go	69.56% <0.00%> (-10.15%)	⬇️
server/tso/local_allocator.go	71.62% <0.00%> (-6.76%)	⬇️
server/statistics/hot_cache_task.go	75.00% <0.00%> (-4.17%)	⬇️
server/member/member.go	64.70% <0.00%> (-2.14%)	⬇️
server/tso/tso.go	60.77% <0.00%> (-0.56%)	⬇️
client/base_client.go	84.37% <0.00%> (-0.53%)	⬇️
server/tso/allocator_manager.go	66.77% <0.00%> (-0.34%)	⬇️
server/cluster/cluster.go	83.01% <0.00%> (+0.47%)	⬆️
... and 11 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 386b044...286220b. Read the comment docs.

[nolouch]

lgtm

[nolouch]

PTAL @bufferflies

[rleungx]

BTW, please update the PR description.

[nolouch]

PTAL @rleungx

[nolouch]

@HunDunDM conflict.

[rleungx]

/hold

[HunDunDM]

/hold cancel

[HunDunDM]

/merge

[ti-chi-bot]

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 286220b

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #4050.

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #4051.