-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
safepoint: support to set safepoints for services #2348
Conversation
Signed-off-by: Shafreeck Sea <[email protected]>
3c53894
to
1bb6604
Compare
Signed-off-by: Shafreeck Sea <[email protected]>
Signed-off-by: Shafreeck Sea <[email protected]>
Signed-off-by: Shafreeck Sea <[email protected]>
Signed-off-by: Shafreeck Sea <[email protected]>
Signed-off-by: Shafreeck Sea <[email protected]>
Signed-off-by: Shafreeck Sea <[email protected]>
@disksing @nolouch The feature is reimplemented and please review it again. The original API and data are left unchanged. A new API called |
Signed-off-by: Shafreeck Sea <[email protected]>
Signed-off-by: Shafreeck Sea <[email protected]>
Signed-off-by: Shafreeck Sea <[email protected]>
Signed-off-by: Shafreeck Sea <[email protected]>
Signed-off-by: Shafreeck Sea <[email protected]>
Signed-off-by: Shafreeck Sea <[email protected]>
Signed-off-by: Shafreeck Sea <[email protected]>
Signed-off-by: Shafreeck Sea <[email protected]>
Signed-off-by: Shafreeck Sea <[email protected]>
Signed-off-by: Shafreeck Sea <[email protected]>
/run-all-tests |
Signed-off-by: Shafreeck Sea [email protected]
What problem does this PR solve?
When a TiKV cluster has multiple components rely on the GC safe point, they should have agreement of value of safe point which determines what data would be deleted.
For example, TiCDC captures the data change event after the safe point, if the safe point advances too quickly, TiCDC can not handle the case.
This PR relies on pingcap/kvproto#603
What is changed and how it works?
UpdateServiceGCSafePoint
to update the safe point for service and return the minimum value across all the servicesRelease note
Check List
Tests
Code changes