store/gc_worker: Implement adaptive GC safePoint (#16550) #16757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shafreeck
approved these changes
Apr 23, 2020
youjiali1995
approved these changes
Apr 23, 2020
bb7133
added
status/LGT1
bb7133
approved these changes
Apr 23, 2020
bb7133
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picks #16550
What problem does this PR solve?
Problem Summary: This PR implements self-adaptive safePoint. After this change, every service upon TiKV (including TiDB) may set its own service safePoint, which means how much data key want to retain after GC. After finishing resolveLocks phase, TiDB's GCWorker will update TiDB's service safePoint and then get the minimal service safePoints among all services, and use it to do the data cleanup.
What is changed and how it works?
What's Changed:
Added a step that tries to update service safePoint and use the minimal service safePoint (if any) to do data clean up work.
Related changes
pingcap/docs/pingcap/docs-cn:pingcap/tidb-ansible:Check List
Tests
Side effects
pdparameter which is required to update service safePoint.Release note