*: Parameterize hotspot scheduling and adjust hot cache #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nolouch <[email protected]>
nolouch
added
component/schedule
Signed-off-by: nolouch <[email protected]>
nolouch
removed
the
do-not-merge/work-in-progress
nolouch
changed the title
Signed-off-by: nolouch <[email protected]>
Signed-off-by: nolouch <[email protected]>
Signed-off-by: nolouch <[email protected]>
rleungx
reviewed
Mar 17, 2020
| @@ -228,7 +230,7 @@ func (h *hotScheduler) gcRegionPendings() { | |||
| empty := true | |||
| for ty, op := range pendings { | |||
| if op != nil && op.IsEnd() { | |||
| if time.Now().After(op.GetCreateTime().Add(minRegionScheduleInterval)) { | |||
| if time.Now().After(op.GetCreateTime().Add(h.conf.GetMaxZombieDuration())) { | |||
There was a problem hiding this comment.
Yes, it still influences the store, which should be consistent with the pendingSum.
disksing
reviewed
Mar 17, 2020
Signed-off-by: nolouch <[email protected]>
Signed-off-by: nolouch <[email protected]>
Signed-off-by: nolouch <[email protected]>
disksing
reviewed
Mar 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #2239 +/- ##
==========================================
+ Coverage 76.66% 76.69% +0.03%
==========================================
Files 197 198 +1
Lines 21290 21442 +152
==========================================
+ Hits 16321 16446 +125
- Misses 3761 3784 +23
- Partials 1208 1212 +4
Continue to review full report at Codecov.
|
Signed-off-by: nolouch <[email protected]>
|
/rebuild |
lhy1024
approved these changes
Mar 17, 2020
lhy1024
reviewed
Mar 17, 2020
|
Hi, @lhy1024 I update the test result in the issue comment, you can check it now. |
lhy1024
approved these changes
Mar 17, 2020
rleungx
reviewed
Mar 17, 2020
rleungx
reviewed
Mar 17, 2020
Signed-off-by: nolouch <[email protected]>
Signed-off-by: nolouch <[email protected]>
rleungx
approved these changes
Mar 18, 2020
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
nolouch
added a commit
to nolouch/pd
that referenced
this pull request
Apr 10, 2020
Signed-off-by: nolouch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nolouch [email protected]
What problem does this PR solve?
Improve stability and let hot region configurable.
What is changed and how it works?
Check List
Tests
Command: sysbench oltap_read_only (table size=2000000, threads=300)
Before:
After: