Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: prevent misoperation when there are tiflash nodes #2242

Merged
merged 3 commits into from
Mar 17, 2020

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Mar 16, 2020

Signed-off-by: disksing [email protected]

What problem does this PR solve?

Fix #2237

What is changed and how it works?

  • When placement rules not enabled, don't allow add tiflash node.
  • When the cluster has tiFlash nodes, don't allow disable placement rules.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

@disksing disksing added the needs-cherry-pick-release-3.1 The PR needs to cherry pick to release-3.1 branch. label Mar 16, 2020
@disksing disksing added this to the v4.0.0-rc milestone Mar 16, 2020
@disksing disksing requested a review from rleungx March 16, 2020 08:43
Signed-off-by: disksing <[email protected]>
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rleungx
Copy link
Member

rleungx commented Mar 17, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 17, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Mar 17, 2020

@disksing merge failed.

@disksing
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 17, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Mar 17, 2020

cherry pick to release-3.1 in PR #2254

@disksing disksing deleted the tiflash-rules branch March 17, 2020 10:03
nolouch pushed a commit that referenced this pull request Mar 17, 2020
)

* server: prevent misoperation when there are tiflash nodes

Signed-off-by: disksing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-3.1 The PR needs to cherry pick to release-3.1 branch. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent add TiFlash Nodes without placement rules
4 participants