Update to update_*_defaults()
#5781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: look into feasibility of the suggestion here: #4993 (comment) |
thomasp85
approved these changes
Apr 2, 2024
R/geom-defaults.R
Outdated
Comment on lines
65
to
67
| if (!index %in% ls(cache_defaults)) { | ||
| cache_defaults[[index]] <- old | ||
| } |
There was a problem hiding this comment.
Maybe overengineering it, but this is a rather unperformant way to check for existence in an environment as it ignores the whole hash structure. exists() are there to check for bindings in an environment
teunbrand
added a commit
to teunbrand/ggplot2
that referenced
this pull request
Apr 12, 2024
This reverts commit 60407ac.
teunbrand
added a commit
to teunbrand/ggplot2
that referenced
this pull request
Apr 12, 2024
This reverts commit 60407ac.
teunbrand
added a commit
to teunbrand/ggplot2
that referenced
this pull request
Apr 15, 2024
This reverts commit 60407ac.
teunbrand
added a commit
to teunbrand/ggplot2
that referenced
this pull request
Apr 18, 2024
* unify updating mechanism * add tests * redocument * add news bullet * add review suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #4993 and supersedes #5098.
Briefly:
new = NULL.In contrast to #5098: