Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with future ggplot2 #79

Merged
merged 4 commits into from
Sep 14, 2024

Conversation

teunbrand
Copy link
Contributor

Hi Garrick,

In ggplot2, we've made updates to update_geom_defaults() (tidyverse/ggplot2#5781) that turned out to be incompatible with {xaringanthemer}.
The issue stems from theme_xaringan_restore_defaults() where the old_ggplot_defaults cache became invalid due to having both spellings of colour and color.
This is prevented by using colour as ggplot2 uses internally.

Feel free to test out with the development branch of ggplot2:

pak::pak("tidyverse/ggplot2")

Our plans for the next release of ggplot2 are still very far away, so there is no hurry in this.

Copy link
Owner

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @teunbrand!

@gadenbuie gadenbuie merged commit fc0ff80 into gadenbuie:main Sep 14, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants