Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new arguments from tune #52

Merged
merged 5 commits into from
Dec 23, 2023
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: agua
Title: 'tidymodels' Integration with 'h2o'
Version: 0.1.3
Version: 0.1.3.9000
Authors@R: c(
person("Max", "Kuhn", , "[email protected]", role = "aut",
comment = c(ORCID = "0000-0003-2402-136X")),
Expand Down Expand Up @@ -35,7 +35,7 @@ Imports:
stats,
tibble,
tidyr,
tune (>= 1.0.1),
tune (>= 1.1.2.9007),
vctrs,
workflows
Suggests:
Expand All @@ -50,6 +50,8 @@ Config/Needs/website:
doParallel,
tidymodels,
vip
Remotes:
tidymodels/tune#793
Config/testthat/edition: 3
Config/testthat/parallel: false
Encoding: UTF-8
Expand Down
8 changes: 6 additions & 2 deletions R/tune.R
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ tune_grid_loop_iter_agua <- function(split,
workflow,
metrics,
control,
seed) {
eval_time = NULL,
seed,
metrics_info = NULL,
params = NULL) {
h2o::h2o.no_progress(
tune_grid_loop_iter_agua_impl(
split,
Expand Down Expand Up @@ -309,7 +312,8 @@ pull_h2o_metrics <- function(predictions,
metrics,
param_names,
outcome_name,
event_level
event_level,
metrics_info = tune::metrics_info(metrics)
)
metrics %>% dplyr::bind_cols(fold_id)
}
Expand Down
Loading