Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 2/2, following up on tidymodels/tune#784. Will add some further context there.
I believe the censored regression mode isn't available in h2o anyway, so we'll never actually hit a point where a non-NULL
eval_time
makes it to this machinery.The remaining changes, for
metrics_info
andparams
, are optional performance optimizations from recent versions of tune.I believe all of the tune-related tests in this repo are skipped on CRAN. This would mean that tune goes in first, tuning with agua is broken for the meantime (as it already is), and then we submit agua once tune is ready to go.