Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new arguments from tune #52

Merged
merged 5 commits into from
Dec 23, 2023
Merged

add new arguments from tune #52

merged 5 commits into from
Dec 23, 2023

Conversation

simonpcouch
Copy link
Collaborator

PR 2/2, following up on tidymodels/tune#784. Will add some further context there.

I believe the censored regression mode isn't available in h2o anyway, so we'll never actually hit a point where a non-NULL eval_time makes it to this machinery.

The remaining changes, for metrics_info and params, are optional performance optimizations from recent versions of tune.

I believe all of the tune-related tests in this repo are skipped on CRAN. This would mean that tune goes in first, tuning with agua is broken for the meantime (as it already is), and then we submit agua once tune is ready to go.

@simonpcouch
Copy link
Collaborator Author

@qiushiyan, I'll request review from another on the team to make sure this is the approach we'd like to go with. Once we feel good about this route, I'll merge the tune PR, update the Remotes here, and then request your review here!

@simonpcouch simonpcouch requested a review from hfrick December 18, 2023 19:24
Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, there is no censored regression with h2o 👍

@simonpcouch
Copy link
Collaborator Author

Feel free to holler if you have any questions about this one, @qiushiyan! After merge, we'd ask that a new version of agua goes to CRAN once dev tune is sent to CRAN, some time in mid-January.

@qiushiyan
Copy link
Collaborator

Thanks @simonpcouch! I will submit agua once tune is ready.

@qiushiyan qiushiyan merged commit 6a742f6 into main Dec 23, 2023
5 checks passed
@hfrick hfrick deleted the tune-784 branch January 2, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants