-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Player] Prepare module for event producer #91
Open
enjikaka
wants to merge
9
commits into
main
Choose a base branch
from
add-event-sender
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+64
−29
Open
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
108ada8
Add setEventSender to player module and export EventSender namespace …
enjikaka 07bebf0
Merge branch 'main' into add-event-sender
enjikaka c077b11
Update lockfile
enjikaka 4cc0a0c
Merge branch 'main' into add-event-sender
enjikaka 82e790d
Bump version and update changelog
enjikaka ee8de80
Merge branch 'main' of github.com:tidal-music/tidal-sdk-web
enjikaka 7e57cc5
Merge branch 'main' into add-event-sender
enjikaka c956aac
merge
enjikaka eae57fb
Fix dep
enjikaka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
import type * as _EventSender from '@tidal-music/event-producer'; | ||
|
||
export type EventSender = typeof _EventSender; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,13 @@ export default defineConfig({ | |
formats: ['es'], | ||
}, | ||
}, | ||
plugins: [dts({ rollupTypes: true, tsconfigPath: 'tsconfig.build.json' })], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
plugins: [ | ||
dts({ | ||
// Bundle the event sender types from event-producer | ||
bundledPackages: ['@tidal-music/event-producer'], | ||
tsconfigPath: 'tsconfig.build.json', | ||
}), | ||
], | ||
test: { | ||
coverage: { | ||
exclude: ['./src/index.ts'].concat(configDefaults.coverage.exclude ?? []), // ignore barrel file | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import type { EventSender } from '@tidal-music/common'; | ||
|
||
import { eventSenderStore } from '../index'; | ||
|
||
/** | ||
* Set the credentials provider TIDAL Player SDK should use for getting | ||
* session information | ||
* | ||
* @param {CredentialsProvider} newCredentialsProvider | ||
andymartinwork marked this conversation as resolved.
Show resolved
Hide resolved
|
||
*/ | ||
export function setEventSender(newEventSender: EventSender) { | ||
eventSenderStore.eventSender = newEventSender; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Common should not be allowed to import from any SDK module I think, or else we create circular dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For type imports it's fine!