[Player] Prepare module for event producer #91
+64
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as type/interface in common.
enjikaka
commented
Mar 21, 2024
| @@ -9,7 +9,13 @@ export default defineConfig({ | |||
| formats: ['es'], | |||
| }, | |||
| }, | |||
| plugins: [dts({ rollupTypes: true, tsconfigPath: 'tsconfig.build.json' })], | |||
There was a problem hiding this comment.
Had to remove rollupTypes due to:
There was a problem hiding this comment.
osmestad
reviewed
Mar 26, 2024
| @@ -0,0 +1,3 @@ | |||
| import type * as _EventSender from '@tidal-music/event-producer'; | |||
There was a problem hiding this comment.
Common should not be allowed to import from any SDK module I think, or else we create circular dependencies?
There was a problem hiding this comment.
For type imports it's fine!
enjikaka
changed the title
|
I have a couple of more questions :-)
|
The idea was to have the same flow as for the CredentialsProvider. I'll change so the player uses it directly.
w/o rollupTypes it was needed not not include the entire EP in Common if I remember correctly. Pushed a commit in the other PR to use EP directly -> 95064cf |
|
When you get back, we should try and get this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modelled after setCredentialsProvider for consistency.