Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EdkRepo: Update Error Codes in edkrepo_exception.py #96

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

shree256
Copy link

@shree256 shree256 commented Sep 17, 2022

Updates error codes in edkrepo_exception.py to consecutive order starting at 100x.

Resolves issue #84

Signed-off-by: Shreeshan Panicker shreeshan.p@yahoo.com
Reviewed-by: Nate DeSimone nathaniel.l.desimone@intel.com
Reviewed-by: Ashley DeSimone ashley.e.desimone@intel.com

@shree256
Copy link
Author

Hie @ashedesimone @nate-desimone,
Ran into some issue while fixing mentioned comments over #88, so created new one.
This contains fixes mentioned in #88.
Please review.

Copy link
Contributor

@ashedesimone ashedesimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates they look good.

I see that there are now 2 commits on this PR branch. Please remove the second commit.

@ashedesimone
Copy link
Contributor

If you need assistance with updating the PR branch I can help please let me know. I will need push access to the branch on your fork in that case.

@shree256
Copy link
Author

shree256 commented Sep 21, 2022

Please assist me.
Have sent you invite for the access.
Thanks.

Updates error codes in edkrepo_exception.py to consecutive order starting at 100x.

Resolves issue tianocore#84

Signed-off-by: Shreeshan Panicker <shreeshan.p@yahoo.com>
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
Reviewed-by: Ashley DeSimone <ashley.e.desimone@intel.com>
@ashedesimone
Copy link
Contributor

Please assist me. Have sent you invite for the access. Thanks.

Hi I rebased the branch you are sending your PR from to be up to date with main, removed the merge commit and placed the commit with your change on top.

@ashedesimone ashedesimone merged commit a8dc2cf into tianocore:main Sep 21, 2022
@shree256
Copy link
Author

shree256 commented Sep 21, 2022

Got it. Thanks for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants