Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EdkRepo: Update Error Codes in edkrepo_exception.py #88

Closed
wants to merge 0 commits into from
Closed

EdkRepo: Update Error Codes in edkrepo_exception.py #88

wants to merge 0 commits into from

Conversation

shree256
Copy link

@shree256 shree256 commented Sep 13, 2022

Updates error codes in edkrepo_exception.py to consecutive order starting at 100x.

Resolves issue #84

Signed-off-by: Shreeshan Panicker [email protected]
Reviewed-by: Nate DeSimone [email protected]
Reviewed-by: Ashley DeSimone [email protected]

@shree256 shree256 changed the title Modify error codes EdkRepo: Update Error Codes in edkrepo_exception.py Sep 13, 2022
@nate-desimone
Copy link
Member

Your code change looks good! However, you are missing "Signed-off-by: Shreeshan Panicker [email protected]" in the commit message. Please amend your commit message to add that. You are also welcome to add "Reviewed-by: Nate DeSimone [email protected]" to your commit message at the same time.

Copy link
Contributor

@ashedesimone ashedesimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Shreeshan,

The code change looks good however can you please amend your commit message to include the info you put in the conversation tab specifically the following:

image

During your editing of the commit message you can also add "Reviewed-by: Ashley DeSimone [email protected]
Thanks!

@nate-desimone
Copy link
Member

This is a good example of how we format the metadata on our commit messages:

72a2cab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants