Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 32-bit linux build target for Travis #389

Merged
merged 7 commits into from
Dec 2, 2019
Merged

Add 32-bit linux build target for Travis #389

merged 7 commits into from
Dec 2, 2019

Conversation

thrasher-
Copy link
Collaborator

Description

Adds a 32 bit build job for Travis to ensure that our codebase works on 32 bit systems due to finding and resolving this issue:

#388

Type of change

Please delete options that are not relevant and add an x in [] as item is complete.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Travis CI and local testing on a 32 bit system

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally and on Travis with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@shazbert shazbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Collaborator

@gloriousCode gloriousCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uTACK ☁️ 👾 🖲 🚈

@thrasher- thrasher- changed the title Adds 32-bit linux build target for Travis Add 32-bit linux build target for Travis Nov 29, 2019
Copy link
Contributor

@xtda xtda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@thrasher- thrasher- merged commit c27b865 into engine Dec 2, 2019
@thrasher- thrasher- deleted the 32bit_testing branch December 2, 2019 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants