-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use sync.Mutex instead of sync/atomic for 32 bit systems and fixes line endings for autocomplete files #388
Conversation
Change CLRF -> LF
Codecov Report
@@ Coverage Diff @@
## engine #388 +/- ##
==========================================
- Coverage 41.43% 41.43% -0.01%
==========================================
Files 167 167
Lines 38218 38224 +6
==========================================
+ Hits 15836 15837 +1
- Misses 21276 21281 +5
Partials 1106 1106
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 zsh autocomplete working awesome now
docker builds also happy and working
Approved!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK! I did not test the autocomplete. Docker works 🌮 🌮 🌮
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Description
Fixes the following issues brought up when reviewing #382
Namely;
a) Docker crash issue (32 bit OS) due to usage of sync/atomic.
b) Specific usage of int64 for Huobi types to fix test failures
c) Changes line endings from CRLF to LF
Type of change
How Has This Been Tested?
go test ./... on a 32 bit OS
Checklist: