Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sync.Mutex instead of sync/atomic for 32 bit systems and fixes line endings for autocomplete files #388

Merged
merged 1 commit into from
Nov 28, 2019

Conversation

thrasher-
Copy link
Collaborator

Description

Fixes the following issues brought up when reviewing #382

Namely;

a) Docker crash issue (32 bit OS) due to usage of sync/atomic.
b) Specific usage of int64 for Huobi types to fix test failures
c) Changes line endings from CRLF to LF

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

go test ./... on a 32 bit OS

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally and on Travis with my changes
  • Any dependent changes have been merged and published in downstream modules

@thrasher- thrasher- requested review from xtda, shazbert, gloriousCode and MadCozBadd and removed request for xtda November 28, 2019 03:24
@codecov
Copy link

codecov bot commented Nov 28, 2019

Codecov Report

Merging #388 into engine will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           engine     #388      +/-   ##
==========================================
- Coverage   41.43%   41.43%   -0.01%     
==========================================
  Files         167      167              
  Lines       38218    38224       +6     
==========================================
+ Hits        15836    15837       +1     
- Misses      21276    21281       +5     
  Partials     1106     1106
Impacted Files Coverage Δ
exchanges/nonce/nonce.go 100% <100%> (ø) ⬆️
database/models/postgres/psql_upsert.go 91.17% <0%> (-8.83%) ⬇️
database/models/postgres/audit_event.go 51.84% <0%> (-1.31%) ⬇️
dispatch/dispatch.go 88.2% <0%> (-0.52%) ⬇️
exchanges/websocket/wshandler/wshandler.go 71.54% <0%> (+0.6%) ⬆️
ntpclient/ntpclient.go 88.88% <0%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e20d204...fb53498. Read the comment docs.

Copy link
Collaborator

@shazbert shazbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK !

Copy link
Contributor

@xtda xtda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 zsh autocomplete working awesome now
docker builds also happy and working

Approved!

Copy link
Collaborator

@gloriousCode gloriousCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK! I did not test the autocomplete. Docker works 🌮 🌮 🌮

Copy link
Contributor

@MadCozBadd MadCozBadd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@thrasher- thrasher- merged commit d636882 into engine Nov 28, 2019
@thrasher- thrasher- deleted the engine_nits branch November 29, 2019 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants