Add tags to jobs and a command line arg to select them #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thp
reviewed
Feb 12, 2024
Jamstah
force-pushed
the
tags
branch
2 times, most recently
from
2d5b32a
to
8b6b90e
Compare
thp
reviewed
Feb 16, 2024
thp
reviewed
Feb 16, 2024
thp
reviewed
Feb 16, 2024
thp
reviewed
Feb 16, 2024
thp
requested changes
Feb 16, 2024
This allows the user to selectively run jobs based on a tag for use cases where you might want to run urlwatch on different schedules for different jobs and other use cases. Signed-off-by: James Hewitt <[email protected]>
Signed-off-by: James Hewitt <[email protected]>
|
Thanks, appreciate the thorough review, I still have python reflexes from before 3.x - don't use it often! |
Signed-off-by: James Hewitt <[email protected]>
thp
requested changes
Mar 12, 2024
docs/source/manpage.rst
Outdated
Comment on lines
26
to
27
| indexes or tags of job(s) to run, depending on --tags. | ||
| If using indexes, they are as numbered according to the --list command. |
There was a problem hiding this comment.
Something along the lines of:
Suggested change
| indexes or tags of job(s) to run, depending on --tags. | |
| If using indexes, they are as numbered according to the --list command. | |
| index(es) or tag(s) of job(s) to run. | |
| If --tags is set, JOB will be interpreted as tags, | |
| if not, as index(es) numbered according to the --list command. |
There was a problem hiding this comment.
Done something along those lines :)
lib/urlwatch/jobs.py
Outdated
| @@ -196,7 +197,10 @@ def ignore_error(self, exception): | |||
|
|
|||
| class Job(JobBase): | |||
| __required__ = () | |||
| __optional__ = ('name', 'filter', 'max_tries', 'diff_tool', 'compared_versions', 'diff_filter', 'enabled', 'treat_new_as_changed', 'user_visible_url') | |||
| __optional__ = ('name', 'tags', 'filter', 'max_tries', 'diff_tool', 'compared_versions', 'diff_filter', 'enabled', 'treat_new_as_changed', 'user_visible_url') | |||
There was a problem hiding this comment.
Nitpicky, but:
Suggested change
| __optional__ = ('name', 'tags', 'filter', 'max_tries', 'diff_tool', 'compared_versions', 'diff_filter', 'enabled', 'treat_new_as_changed', 'user_visible_url') | |
| __optional__ = ('name', 'filter', 'max_tries', 'diff_tool', 'compared_versions', 'diff_filter', 'enabled', 'treat_new_as_changed', 'user_visible_url', 'tags') |
There was a problem hiding this comment.
I've moved it, but why at the end? Its not alphanum sorted, and I thought putting it with name made sense as they're both identifying metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the user to selectively run jobs based on a tag for use cases where you might want to run urlwatch on different schedules for different jobs and other use cases.
This is also part 1 of addressing #507 - next up would be allowing the report config to be an array (retaining existing behaviour for maps) and allowing users to assign tags to each reporter.
I am aware this will conflict with #785, and will rebase as required ;)