Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable individual jobs #785

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

Jamstah
Copy link
Contributor

@Jamstah Jamstah commented Jan 17, 2024

This adds an enabled flag for all jobs that allows a user to disable individual jobs without having to comment out lots of lines of yaml.

Fixes #625

Copy link
Owner

@thp thp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice and complete PR, thanks!

Two commends + please update CHANGELOG.md with the additional feature.

docs/source/jobs.rst Outdated Show resolved Hide resolved
lib/urlwatch/jobs.py Outdated Show resolved Hide resolved
@Jamstah
Copy link
Contributor Author

Jamstah commented Jan 23, 2024

Done, thanks for the review.

@Jamstah
Copy link
Contributor Author

Jamstah commented Jan 24, 2024

Should I also be regenerating the man pages, or does that get done at release time?

@thp
Copy link
Owner

thp commented Feb 12, 2024

Should I also be regenerating the man pages, or does that get done at release time?

Can be done at release time.

@thp thp merged commit cb930d7 into thp:master Feb 12, 2024
0 of 5 checks passed
@thp
Copy link
Owner

thp commented Feb 12, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: support optional key disabled
2 participants