Pull normalize.css through Rails Assets #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 8, 2017
| @@ -1,6 +1,6 @@ | |||
| @charset "utf-8"; | |||
|
|
|||
| @import "normalize-rails"; | |||
| @import "normalize-css"; | |||
There was a problem hiding this comment.
Imported partial normalize-css should be written as _normalize-css.scss
There was a problem hiding this comment.
This is an error and will be fixed once thoughtbot/guides#486 gets merged.
The normalize-rails gem has fallen out of date. The current version of normalize.css is 7.0.0, but the latest version of normalize-rails is 4.1.1. There have been repeated requests by collaborators of normalize-rails to be given permissions to deploy new versions, but have gone unfulfilled. With around 7 months of waiting, it seems time to pull in normalize.css through other means. This change uses Rails Assets to get normalize.css. It wraps Bower, which pulls directly through GitHub tags, so it should always up-to-date. Ref: https://github.com/markmcconachie/normalize-rails/issues/23 Closes: #835
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The normalize-rails gem has fallen out of date. The current version of
normalize.css is 7.0.0, but the latest version of normalize-rails is
4.1.1.
There have been repeated requests by collaborators of normalize-rails to
be given permissions to deploy new versions, but have gone unfulfilled.
With around 7 months of waiting, it seems time to pull in normalize.css
through other means. This change uses Rails Assets to get normalize.css.
It wraps Bower, which pulls directly through GitHub tags, so it should
always up-to-date.
Ref: https://github.com/markmcconachie/normalize-rails/issues/23
Closes: #835