Skip to content

Commit

Permalink
Pull normalize.css through Rails Assets
Browse files Browse the repository at this point in the history
The normalize-rails gem has fallen out of date. The current version of
normalize.css is 7.0.0, but the latest version of normalize-rails is
4.1.1.

There have been repeated requests by collaborators of normalize-rails to
be given permissions to deploy new versions, but have gone unfulfilled.

With around 7 months of waiting, it seems time to pull in normalize.css
through other means. This change uses Rails Assets to get normalize.css.
It wraps Bower, which pulls directly through GitHub tags, so it should
always up-to-date.

Ref: https://github.com/markmcconachie/normalize-rails/issues/23
Closes: #835
  • Loading branch information
tysongach committed May 8, 2017
1 parent 718fb7a commit 56fe7b5
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion spec/features/new_project_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ def app_name
expect(read_project_file(flashes_path)).to match(/\$flashes/m)

app_css = read_project_file(%w(app assets stylesheets application.scss))
expect(app_css).to match(/normalize-rails.*bourbon.*neat.*base.*refills/m)
expect(app_css).to match(/normalize-css.*bourbon.*neat.*base.*refills/m)
end

it "doesn't use turbolinks" do
Expand Down
2 changes: 1 addition & 1 deletion templates/Gemfile.erb
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ gem "delayed_job_active_record"
gem "flutie"
gem "honeybadger"
gem "jquery-rails"
gem "normalize-rails", "~> 3.0.0"
gem "pg"
gem "puma"
gem "rack-canonical-host"
gem "rails", "<%= Suspenders::RAILS_VERSION %>"
gem "rails-assets-normalize-css", source: "https://rails-assets.org"
gem "recipient_interceptor"
gem "sass-rails", "~> 5.0"
gem "simple_form"
Expand Down
2 changes: 1 addition & 1 deletion templates/application.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@charset "utf-8";

@import "normalize-rails";
@import "normalize-css";

@import "bourbon";
@import "neat";
Expand Down

0 comments on commit 56fe7b5

Please sign in to comment.