Remove turbolinks from application.js file #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,6 +43,12 @@ def raise_on_delivery_errors | |||
| 'raise_delivery_errors = false', 'raise_delivery_errors = true' | |||
| end | |||
|
|
|||
| def remove_turbolinks | |||
| replace_in_file 'app/assets/javascripts/application.js', | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
Code LGTM. |
| replace_in_file( | ||
| "app/assets/javascripts/application.js", | ||
| "//= require turbolinks", | ||
| '' |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Put a comma after the last parameter of a multiline method call.
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Put a comma after the last parameter of a multiline method call.
Suspenders doesn't use turbolinks by default. It doesn't include it in the Gemfile, but the generated `application.js` was trying to include it, resulting in a failure. This fix make sure a newly generated application doesn't include the turbolinks reference. [fixes #788]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suspenders doesn't use turbolinks by default. It doesn't include it in
the Gemfile, but the generated
application.jswas trying to includeit, resulting in a failure.
This fix make sure a newly generated application doesn't include
the turbolinks reference.
[fixes #788]