Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing turbolinks gem #788

Closed
lorenrogers opened this issue Jul 17, 2016 · 2 comments · Fixed by #792
Closed

Missing turbolinks gem #788

lorenrogers opened this issue Jul 17, 2016 · 2 comments · Fixed by #792

Comments

@lorenrogers
Copy link

Seems like the application js file is sourcing turbolinks, but the gem is missing from the Gemfile. (I didn't have the turbolinks gem installed before, since this is a new machine.) Adding gem "turbolinks" fixed it for me locally -- not sure if this is something needed in Suspenders.
@tute
Copy link
Contributor

tute commented Jul 21, 2016

Right. suspenders didn't include turbolinks for long (#225). @derekprior I know lately you've been using turbolinks with success. Should we revisit our stance on suspenders?

@tute tute mentioned this issue Jul 22, 2016
Merged
tute added a commit that referenced this issue Jul 22, 2016
@tute
Remove turbolinks from application.js file
1146e19 
Suspenders doesn't use turbolinks by default. It doesn't include it in
the Gemfile, but the generated `application.js` was trying to include
it, resulting in a failure.

This fix make sure a newly generated application doesn't include
the turbolinks reference.

[fixes #788]
@tute tute closed this as completed in #792 Jul 22, 2016
@tute
Copy link
Contributor

tute commented Jul 22, 2016

Thanks for reporting, Loren!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove turbolinks from application.js file thoughtbot/suspenders
2 participants
@tute @lorenrogers