Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Resolve: Update npm dependencies (09-10-2021) #1749

Merged
merged 14 commits into from
Sep 10, 2021

Conversation

gromxyz
Copy link
Contributor

@gromxyz gromxyz commented Sep 10, 2021

Verify commands:

  • yarn prebuild
  • yarn generate:types
  • yarn build-storybook
  • yarn storybook

Verfiy functionality:

  • Swap
  • Add/Remove liquidity
  • Tx history
  • Slip tolerance becuase of modified styles for new typescript changes
  • Upgrade ETH.RUNE and BNB.RUNE
  • Send keystore/ledger
  • Swap BTC/ETH/BCH/LTC due to updated xchain clients

Not updated:
@storybook/react - mentioned in #1579
electron - waiting for major upgrade to 15.0.0 (it's in beta at the moment)
eslint-plugin-prettier + prettier - delayed upgrade due to jsxBracketSameLine related bug
ts-loader - mentioned in #1411
cosmos-client - waiting on xchainjs/xchainjs-lib#436 in order to upgrade both
fp-ts - we still use features that are deprecated in https://github.com/gcanti/fp-ts/releases/tag/2.11.1

Closes #1746

@gromxyz gromxyz self-assigned this Sep 10, 2021
@gromxyz gromxyz force-pushed the issue-1746/update-npm-dependencies branch from 0a24e46 to f2c8300 Compare September 10, 2021 13:47
Copy link
Collaborator

@veado veado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - pls add a note about things which could not be updated (similar to last update deps PR)

package.json Show resolved Hide resolved
src/renderer/services/binance/common.ts Show resolved Hide resolved
@gromxyz gromxyz merged commit 419baa1 into develop Sep 10, 2021
@gromxyz gromxyz deleted the issue-1746/update-npm-dependencies branch September 10, 2021 17:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update npm dependencies (09-10-2021)
2 participants