Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Resolve: Update npm dependencies (06-23-2021) #1579

Merged
merged 14 commits into from
Jun 24, 2021
Merged

Conversation

veado
Copy link
Collaborator

@veado veado commented Jun 23, 2021

Notes

ncu
Checking asgardex-electron/package.json
[====================] 105/105 100%

 @storybook/react  ^6.1.21  →   ^6.3.0 // breaks build of storybook, it seems babel loader version is not compatible with current CRA (as mentioned in #1411)
 @types/node        ^14.17  →   ^15.12 // we stick on [email protected] used by [email protected]  
 ts-loader          ^8.3.0  →   ^9.2.3 // not compatible w/ webpack <5.0 - see https://github.com/TypeStrong/ts-loader/releases/tag/v9.0.0
 cosmos-client     ^0.39.2  →  ^0.42.5 // `xchain-cosmos` needs to be updated before
 ethers             ^5.1.4  →   ^5.3.1 // `xchain-ethereum` needs to be updated before 
 rxjs               ^6.6.7  →   ^7.1.0 // `fp-ts-rxjs` + `@devexperts/rx-utils/dist/observable.utils` still depends on [email protected]

Some info about @storybook/react issues

yarn dev
yarn run v1.22.5
$ concurrently --kill-others --success first "yarn:dev:*"
$ wait-on http://localhost:3000 && nodemon -I --watch ./src/main/ --exec electron .
$ cross-env BROWSER=none yarn start:web
$ craco start
[dev:app] 
[dev:app] There might be a problem with the project dependency tree.
[dev:app] It is likely not a bug in Create React App, but something you need to fix locally.
[dev:app] 
[dev:app] The react-scripts package provided by Create React App requires a dependency:
[dev:app] 
[dev:app]   "babel-loader": "8.1.0"
[dev:app] 
[dev:app] Don't try to install it manually: your package manager does it automatically.
[dev:app] However, a different version of babel-loader was detected higher up in the tree:
[dev:app] 
[dev:app]   asgardex-electron/node_modules/babel-loader (version: 8.2.2) 

Check of dependencies for babel-loader

npm ls babel-loader                                                                                      
[email protected] asgardex-electron
├─┬ @storybook/[email protected]
│ ├─┬ @storybook/[email protected]
│ │ └─┬ @storybook/[email protected]
│ │   ├─┬ @storybook/[email protected]
│ │   │ └── [email protected]  deduped
│ │   └─┬ @storybook/[email protected]
│ │     └── [email protected]  deduped
│ └─┬ @storybook/[email protected]
│   └── [email protected] 
└─┬ [email protected]
  └── [email protected] 

That's why we stick on @storybook/[email protected] for now.

Closes #1565

@veado veado self-assigned this Jun 23, 2021
`@storybook/react": "6.1.21`
@veado veado marked this pull request as ready for review June 24, 2021 10:01
@veado veado merged commit d8b0683 into develop Jun 24, 2021
@veado veado deleted the issue-1565/update-deps branch June 24, 2021 10:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update npm dependencies (06-23-2021)
1 participant