Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling close in the CONNECTING state should not cause onopen to be called #383

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Calling close in the CONNECTING state should not cause onopen to be called #383

merged 2 commits into from
Sep 11, 2023

Conversation

steveluscher
Copy link
Contributor

@steveluscher steveluscher commented Sep 8, 2023 •
edited
Loading

  1. A test case that demonstrates the bug described in Calling close() in the CONNECTING state should not result in open callback being called #384.
  2. Code that bails out of the constructor's delayed setup in the event that the socket is no longer in the CONNECTING state.

Fixes #384.

@steveluscher steveluscher mentioned this pull request Sep 8, 2023
Closed
@steveluscher
fix: bail from the WebSocket constructor's delayed setup if the `re…
693b9bc 
…adyState` has changed from `CONNECTING` to something else
@Atrue Atrue merged commit b098586 into thoov:master Sep 11, 2023
6 checks passed
@Atrue
Copy link
Collaborator

Atrue commented Sep 11, 2023

Release 9.3.1. Thanks @steveluscher!

@steveluscher steveluscher deleted the close-while-in-connecting-state-should-not-call-open branch September 11, 2023 06:39
@steveluscher steveluscher mentioned this pull request Sep 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calling close() in the CONNECTING state should not result in open callback being called
2 participants
@steveluscher @Atrue