Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling close() in the CONNECTING state should not result in open callback being called #384

Closed
steveluscher opened this issue Sep 8, 2023 · 0 comments · Fixed by #383
Closed

Calling close() in the CONNECTING state should not result in open callback being called #384

steveluscher opened this issue Sep 8, 2023 · 0 comments · Fixed by #383

Comments

@steveluscher
Copy link
Contributor

When in the CONNECTING state this library does the correct thing:

  • sets the state to CLOSED
  • calls onerror
  • calls close

Problem is that it also calls onopen.

Added a test case in #383 that demonstrates this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Calling close in the CONNECTING state should not cause onopen to be called
1 participant
@steveluscher