route: add nexthop type

[zstas]

The basic support for dumping nexthops and filling the cache.

[zstas]

Hello,
I'm new to libnl, so any feedback is much appreciated. Will be happy to address any comment.
Also, if you think that neighbor changes should be sent in a different PR - I can also do that.

[thom311]

thank you for your patch. I am sorry for the long time it took me to reply. If you lost interest, I understand :( Anyway. Some comments...

[zstas]

Hi Thomas,

Thanks for the review. I tried to address all of them. Also I included another fix in the parser (in the previous patch only 2 group elements were allowed, I've increased it to 64). But unfortunately after rebasing github doesn't allow to compare the previous version with the current. But I've splitted the PR into 4 different commits (as you suggested), perhaps it makes the next review more easy.

I've been using the feature introduced in this patch for almost a year (for parsing fdb nexthops in linux), so I'd like to have this patch merged into upstream. So, I'm ready to improve this patch until you say it's good to go :)

[zstas]

I've addressed all the previous comments.
Also apologies for another last-minute change - since you mentioned nh_clone, I took another look and found that I wasn't copying nh_gateway and nh_group. Addressed that as well (in 3rd commit).

[thom311]

Maybe you could take the patches from https://paste.centos.org/view/3c278476 (well, review them, and take the parts that you agree with).

It also requires you to rebase the branch again to latest main (because they use some new API from main branch).

[zstas]

I intended to merge things from your patch today, but unfortunately the link is expired. Could you please share it one more time?

[thom311]

I didn't realize fpaste expires so fast. Sorry about that. Here again: https://paste.centos.org/view/bba2d453

I also just realized, that a change I did will cause a merge conflict when you rebase. Sorry about that. It should however be easy to resolved... Thanks.

[zstas]

I rebased, applied all your changes and also removed nh_master attribute from rtnl_nh struct (as it wasn't used anywhere). Could you please take a look once again?

[thom311]

merged as bc8573d.

Thank you for your efforts!!!