Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the comment for nl_nh_group_info correct? #356

Closed
irino opened this issue Aug 17, 2023 · 2 comments
Closed

Is the comment for nl_nh_group_info correct? #356

irino opened this issue Aug 17, 2023 · 2 comments

Comments

@irino
Copy link

irino commented Aug 17, 2023

When I read PR #332, I found comments that seem incorrect
https://github.com/thom311/libnl/blob/4c39a2ce1b379c4caa8118ba544b53c9bdb3b687/include/netlink/route/nh.h#L19C25-L19C25

typedef struct nl_nh_group_info {
	uint32_t nh_id; /*!< VLAN number */
	uint8_t weight; /*!< VLAN QOS value */
} nl_nh_group_info_t;

I think the comments should be

typedef struct nl_nh_group_info {
	uint32_t nh_id; /*!< nexthop id */
	uint8_t weight; /*!< weight in nexthop group*/
} nl_nh_group_info_t;
@irino irino changed the title Is this comment correct? Is the comment for nl_nh_group_info correct? Aug 17, 2023
@thom311
Copy link
Owner

thom311 commented Aug 17, 2023

you are right, looks like a copy+paste error. Should be fixed :)

thom311 added a commit that referenced this issue Aug 17, 2023
@thom311
Copy link
Owner

thom311 commented Aug 17, 2023

fixed by 74bffbf

Thanks!!

@thom311 thom311 closed this as completed Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants