Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes Oscar#3841 #1543

Merged
merged 1 commit into from
Jun 12, 2024
Merged

fixes Oscar#3841 #1543

merged 1 commit into from
Jun 12, 2024

Conversation

fieker
Copy link
Collaborator

@fieker fieker commented Jun 12, 2024

ideal comparison had an algorithmic error, leading to rare crashes in the CI (for Oscar)

ideal comparison had an algorithmic error, leading to rare crashes
in the CI (for Oscar)
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.64%. Comparing base (c2acff9) to head (df8786b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1543      +/-   ##
==========================================
- Coverage   75.67%   75.64%   -0.03%     
==========================================
  Files         356      356              
  Lines      113548   113556       +8     
==========================================
- Hits        85926    85905      -21     
- Misses      27622    27651      +29     
Files Coverage Δ
src/NumFieldOrd/NfOrd/Ideal/Ideal.jl 82.81% <92.30%> (+0.02%) ⬆️

... and 26 files with indirect coverage changes

@thofma thofma merged commit 0ff72f1 into master Jun 12, 2024
19 checks passed
@thofma thofma deleted the IdealEq branch June 12, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants