CI failure in G-Module tests

[joschmitt]

The CI failed in the G-Module tests https://github.com/oscar-system/Oscar.jl/actions/runs/9465824798/job/26076152813#step:9:1815 . (It's on nightly, but it appears to be a genuine error to me.)

@fieker @ThomasBreuer

[fieker]

On Tue, Jun 11, 2024 at 09:46:56AM -0700, Johannes Schmitt wrote: The CI failed in the G-Module tests https://github.com/oscar-system/Oscar.jl/actions/runs/9465824798/job/26076152813#step:9:1815 . (It's on nightly, but it appears to be a genuine error to me.) @fieker @ThomasBreuer

I'll have a look

…

-- Reply to this email directly or view it on GitHub: #3841 You are receiving this because you were mentioned. Message ID: ***@***.***>

[fieker]

fixed by thofma/Hecke.jl#1543

[benlorenz]

I just noticed another error during the GModule tests, it does looks different but may be due to the same bug?

Experimental.gmodule: Error During Test at /home/runner/work/Oscar.jl/Oscar.jl/experimental/GModule/test/runtests.jl:26
  Got exception outside of a @test
  not a subgroup
  Stacktrace:
    [1] error(s::String)
      @ Base ./error.jl:44
    [2] quo
      @ ~/.julia/packages/Hecke/7QVcp/src/GrpAb/GrpAbFinGen.jl:1547 [inlined]
    [3] quo(G::FinGenAbGroup, U::FinGenAbGroup)
      @ Hecke ~/.julia/packages/Hecke/7QVcp/src/GrpAb/GrpAbFinGen.jl:1546
    [4] macro expansion
      @ ~/.julia/packages/Hecke/7QVcp/src/Hecke.jl:476 [inlined]
    [5] H_two(C::GModule{PermGroup, FinGenAbGroup}; force_rws::Bool, redo::Bool, lazy::Bool)
      @ Oscar.GrpCoh ~/work/Oscar.jl/Oscar.jl/experimental/GModule/src/Cohomology.jl:1401
    [6] H_two
      @ ~/work/Oscar.jl/Oscar.jl/experimental/GModule/src/Cohomology.jl:1149 [inlined]
    [7] #cohomology_group#257
      @ ~/work/Oscar.jl/Oscar.jl/experimental/GModule/src/Cohomology.jl:1849 [inlined]
    [8] cohomology_group(C::GModule{PermGroup, FinGenAbGroup}, i::Int64)
      @ Oscar.GrpCoh ~/work/Oscar.jl/Oscar.jl/experimental/GModule/src/Cohomology.jl:1835
    [9] local_index(CC::Vector{Oscar.GrpCoh.CoChain{2, PermGroupElem, Oscar.GrpCoh.MultGrpElem{AbsSimpleNumFieldElem}}}, P::AbsSimpleNumFieldOrderIdeal, mG::AbstractAlgebra.Generic.CompositeMap{PermGroup, Hecke.NfMorSet{AbsSimpleNumField}}; B::Nothing, index_only::Bool)
      @ Oscar.GaloisCohomology_Mod ~/work/Oscar.jl/Oscar.jl/experimental/GModule/src/GaloisCohomology.jl:1317
   [10] local_index
      @ ~/work/Oscar.jl/Oscar.jl/experimental/GModule/src/GaloisCohomology.jl:1289 [inlined]
   [11] local_index(CC::Oscar.GrpCoh.CoChain{2, PermGroupElem, Oscar.GrpCoh.MultGrpElem{AbsSimpleNumFieldElem}}, P::AbsSimpleNumFieldOrderIdeal, mG::AbstractAlgebra.Generic.CompositeMap{PermGroup, Hecke.NfMorSet{AbsSimpleNumField}}; B::Nothing, index_only::Bool)
      @ Oscar.GaloisCohomology_Mod ~/work/Oscar.jl/Oscar.jl/experimental/GModule/src/GaloisCohomology.jl:1217
   [12] local_schur_indices(c::Oscar.GrpCoh.CoChain{2, PermGroupElem, Oscar.GrpCoh.MultGrpElem{AbsSimpleNumFieldElem}}, mG::AbstractAlgebra.Generic.CompositeMap{PermGroup, Hecke.NfMorSet{AbsSimpleNumField}}; primes::Vector{Any})
      @ Oscar.GModuleFromGap ~/work/Oscar.jl/Oscar.jl/experimental/GModule/src/GModule.jl:460
   [13] local_schur_indices(c::Oscar.GrpCoh.CoChain{2, PermGroupElem, Oscar.GrpCoh.MultGrpElem{AbsSimpleNumFieldElem}}, mG::AbstractAlgebra.Generic.CompositeMap{PermGroup, Hecke.NfMorSet{AbsSimpleNumField}})
      @ Oscar.GModuleFromGap ~/work/Oscar.jl/Oscar.jl/experimental/GModule/src/GModule.jl:431
   [14] _minimize(V::GModule{PcGroup, AbstractAlgebra.Generic.FreeModule{AbsSimpleNumFieldElem}})
      @ Oscar.GModuleFromGap ~/work/Oscar.jl/Oscar.jl/experimental/GModule/src/GModule.jl:542
   [15] iterate
      @ ./generator.jl:48 [inlined]
   [16] collect_to!(dest::Vector{GModule{PcGroup, AbstractAlgebra.Generic.FreeModule{AbsSimpleNumFieldElem}}}, itr::Base.Generator{Vector{GModule}, typeof(Oscar.GModuleFromGap._minimize)}, offs::Int64, st::Int64)
      @ Base ./array.jl:829
   [17] collect_to_with_first!(dest::Vector{GModule{PcGroup, AbstractAlgebra.Generic.FreeModule{AbsSimpleNumFieldElem}}}, v1::GModule{PcGroup, AbstractAlgebra.Generic.FreeModule{AbsSimpleNumFieldElem}}, itr::Base.Generator{Vector{GModule}, typeof(Oscar.GModuleFromGap._minimize)}, st::Int64)
      @ Base ./array.jl:807
   [18] _collect(c::Vector{GModule}, itr::Base.Generator{Vector{GModule}, typeof(Oscar.GModuleFromGap._minimize)}, ::Base.EltypeUnknown, isz::Base.HasShape{1})
      @ Base ./array.jl:801
   [19] collect_similar
      @ ./array.jl:700 [inlined]
   [20] map
      @ ./abstractarray.jl:3396 [inlined]
   [21] irreducible_modules(::Type{AbsSimpleNumField}, G::PcGroup; minimal_degree::Bool)
      @ Oscar.GModuleFromGap ~/work/Oscar.jl/Oscar.jl/experimental/GModule/src/GModule.jl:410
   [22] top-level scope
      @ ~/work/Oscar.jl/Oscar.jl/experimental/GModule/test/runtests.jl:27
   [23] macro expansion
      @ /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.12/Test/src/Test.jl:1700 [inlined]
   [24] macro expansion
      @ ~/work/Oscar.jl/Oscar.jl/experimental/GModule/test/runtests.jl:42 [inlined]
   [25] include
      @ ./Base.jl:561 [inlined]
   [26] macro expansion
      @ ./timing.jl:578 [inlined]
   [27] _timed_include(str::String, mod::Module; use_ctime::Bool)
      @ Oscar ~/work/Oscar.jl/Oscar.jl/src/utils/tests.jl:5
   [28] _timed_include (repeats 2 times)
      @ ~/work/Oscar.jl/Oscar.jl/src/utils/tests.jl:1 [inlined]
   [29] (::Oscar.var"#34#35"{Bool, Bool, Bool, Vector{Any}})()
      @ Oscar ~/work/Oscar.jl/Oscar.jl/src/utils/tests.jl:258
   [30] with_unicode(f::Oscar.var"#34#35"{Bool, Bool, Bool, Vector{Any}}, allowed::Bool)
      @ AbstractAlgebra.PrettyPrinting ~/.julia/packages/AbstractAlgebra/EYoda/src/PrettyPrinting.jl:1766
   [31] #test_module#33
      @ ~/work/Oscar.jl/Oscar.jl/src/utils/tests.jl:206 [inlined]
   [32] test_module
      @ ~/work/Oscar.jl/Oscar.jl/src/utils/tests.jl:205 [inlined]
   [33] #37
      @ ~/work/Oscar.jl/Oscar.jl/test/runtests.jl:155 [inlined]
   [34] (::Base.var"#1167#1172"{var"#37#38"})(r::Base.RefValue{Any}, args::Tuple{String})
      @ Base ./asyncmap.jl:94
   [35] (::Base.var"#1183#1184"{Base.var"#1167#1172"{var"#37#38"}, Channel{Any}, Nothing})()
      @ Base ./asyncmap.jl:228
Test Summary:        | Pass  Error  Total     Time
Experimental.gmodule |    4      1      5  1m17.2s
ERROR: LoadError: LoadError: Some tests did not pass: 4 passed, 0 failed, 1 errored, 0 broken.
in expression starting at /home/runner/work/Oscar.jl/Oscar.jl/experimental/GModule/test/runtests.jl:26

From https://github.com/oscar-system/Oscar.jl/actions/runs/9485312779/job/26136933758?pr=3851#step:9:1805

[fieker]

it's not the same bug. There seem to be very intermittend failures in the code, weather in Hecke, Nemo or Oscar, I don't know. It is doing a lot of fiddly computations with many objects, some of them imprecise. I am running this now in a loop several 100 times, I've seen a different error than above, once.... hard to repreoduce