Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and unify docs about maximal lattices #1307

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

StevellM
Copy link
Collaborator

@StevellM StevellM commented Dec 2, 2023

Follows from #1288

@thofma
Copy link
Owner

thofma commented Dec 2, 2023

Tests are failing.

@simonbrandhorst do you want to have a look?

Remove what shouldn't have been removed, somehow...
Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Merging #1307 (077bfdd) into master (53be492) will increase coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1307      +/-   ##
==========================================
+ Coverage   74.43%   74.46%   +0.02%     
==========================================
  Files         346      346              
  Lines      111802   111807       +5     
==========================================
+ Hits        83225    83255      +30     
+ Misses      28577    28552      -25     
Files Coverage Δ
src/QuadForm/Herm/Lattices.jl 97.57% <100.00%> (+0.02%) ⬆️
src/QuadForm/Lattices.jl 87.61% <ø> (ø)
src/QuadForm/Quad/Lattices.jl 96.64% <100.00%> (+0.01%) ⬆️
src/QuadForm/Quad/ZLattices.jl 92.83% <100.00%> (ø)

... and 33 files with indirect coverage changes

src/QuadForm/Herm/Lattices.jl Outdated Show resolved Hide resolved
src/QuadForm/Lattices.jl Outdated Show resolved Hide resolved
@simonbrandhorst simonbrandhorst merged commit 8a92d8f into thofma:master Dec 4, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants