Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant conditional that doesn't affect outcome. #73

Closed
wants to merge 1 commit into from

Conversation

jmm
Copy link
Collaborator

@jmm jmm commented Dec 18, 2014

This conditional doesn't appear to serve any purpose currently. Tests pass.

@domenic
Copy link
Collaborator

domenic commented Dec 18, 2014

This was added in #69 by @guzart. I guess we didn't do a good job of checking whether the test was necessary? Or maybe, it was obsoleted by subsequent changes.

@jmm
Copy link
Collaborator Author

jmm commented Dec 18, 2014

Yeah, sorry, I probably should've figured out and explained the context a bit more. I think it might have to do with switching to using source maps generated by traceur instead of generating them in es6ify. I think I got started down this road from #68.

@jmm
Copy link
Collaborator Author

jmm commented Dec 18, 2014

Looks like it was obsoleted by subsequent changes. There were 2 consecutive commits where the line was added (d375cf9) to solve a problem with source map generation, then in the next commit (5ff0da9) all of that logic was removed, in favor of using source maps generated by traceur, except for this line. Just an oversight apparently.

@domenic
Copy link
Collaborator

domenic commented Dec 19, 2014

Thanks, merged as 627e999

@domenic domenic closed this Dec 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants