Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix using sourcemap generator when there is no sourcemap #69

Closed
wants to merge 1 commit into from
Closed

Fix using sourcemap generator when there is no sourcemap #69

wants to merge 1 commit into from

Conversation

guzart
Copy link
Collaborator

@guzart guzart commented Dec 7, 2014

Fixes #64

@domenic
Copy link
Collaborator

domenic commented Dec 7, 2014

Probably should have a test...

@Aaike
Copy link

Aaike commented Dec 9, 2014

👍 This works , im using it to disable sourcemaps with traceurOverrides = { sourceMaps: false }

please merge it :)

@domenic
Copy link
Collaborator

domenic commented Dec 9, 2014

Needs a test before it can be merged

@thlorenz
Copy link
Owner

thlorenz commented Dec 9, 2014

Yeah, just add a test case for exactly the situation you describe to turn off sourcemaps.

@guzart
Copy link
Collaborator Author

guzart commented Dec 10, 2014

Test case added. I think it makes sense for the test to be on the transform instead of the bundle.

@domenic
Copy link
Collaborator

domenic commented Dec 12, 2014

Thanks, merged as d375cf9

@domenic domenic closed this Dec 12, 2014
@domenic domenic mentioned this pull request Dec 18, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Turning off sourcemaps fails
4 participants
@guzart @domenic @Aaike @thlorenz